빅챗 스프레드 시트 생성 후 GOGO 이모지를 누른 사람들을 일괄 등록하도록 기능 구현 (#89) #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hepheir
changed the title
hepheir
commented
Aug 2, 2024
Comment on lines
+49
to
+52
| self.gs_client.append_row(worksheet_id, member.transform_for_spreadsheet()) | ||
| finally: | ||
| if error_message: | ||
| self.slack_client.send_message(msg=error_message, ts=self.ts) |
There was a problem hiding this comment.
사용자가 시트에 추가 된 뒤, 슬렉으로 사용자 정보를 보내주는 부분은 가져오지 못했네요.
해당 부분에 대한 수정이 추가로 필요할 것 같습니다.
|
@sudosubin 님이 최종 리뷰어인걸로 하시죠 (한명밖에 안넣어짐..) 저도 리뷰는 하겠습니다 |
roeniss
reviewed
Aug 3, 2024
Comment on lines
+101
to
+102
| def get_emoji(self, channel: str, ts: str, emoji_name: str) -> Optional[Reaction]: | ||
| """channel에 있는 ts 시간에 발송된 메시지에 사용자들이 남긴 반응 목록을 가져온다. |
There was a problem hiding this comment.
이렇게 하면 정확히 "ts 시간에" 남긴 반응만 가져오지 않나요? 밀리세컨드 단위로 찍히는 것 같아서요
Comment on lines
+34
to
+37
| reaction = self.slack_client.get_emoji( | ||
| channel=channel, | ||
| timestamp=self.ts, | ||
| ) |
There was a problem hiding this comment.
이 라인을 지나간 직후에 생성되는 이모지는 어떻게 되는걸까요? 여전히 하나의 처리되지 못한 이모지로 남게 될까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #89
빅챗 시트가 생성되기 이전에 등록을 시도한 사람들에 대하여, 시트 생성 직후 일괄 추가하도록 하였습니다.
!!! 실제 슬렉 환경에서는 테스트 해보지 않았습니다.