Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorg release #7429

Merged
merged 31 commits into from
Aug 28, 2022
Merged

Sorg release #7429

merged 31 commits into from
Aug 28, 2022

Conversation

jbrider
Copy link
Contributor

@jbrider jbrider commented Aug 7, 2022

working on #572

@jbrider
Copy link
Contributor Author

jbrider commented Aug 16, 2022

@hol353 This can be merged and released. The documentation is in a usable state - I will keep making some improvements to it when I get a chance but it doesn't need to hold it up any longer.

@hol353
Copy link
Contributor

hol353 commented Aug 17, 2022

@jbrider
@APSIMInitiative/reference-panel

Well done on getting the sorghum model ready for release. I don't want to hold it up but Neil and I have a couple of questions about the sorghum model:

  • Is MicroClimate's calculated PotentialEP value used in sorghum? From looking through the source code I can't find anywhere it is used.
  • Given the narrow validation range (Gatton, Hermitage, Icrisat) can you add a plausibility test i.e. a range of locations of different climate types. Other crop models have this that you could probably easily copy.
  • In your PPT to the RP (RP Meeting - 2 November 2021 - Review of Sorghum Model ReferencePanel#96) you show a plausibility 'Time of Sowing' test. Where is that?
  • Sorghum is used as a dual purpose crop in this part of the world. Can you show a test where animals reduce the leaf area? Other models have tests that you could copy.

I don't think any of this would take long as there are existing examples that you can copy and modify.

@jbrider
Copy link
Contributor Author

jbrider commented Aug 18, 2022

The SorghumPlausibilityRuns files has 6 simulations in it including:

  • Sowing Date which is the time of sowing example
  • Intercropping which shows how to enable Microclimate in a shared cropping situation as presented and discussed during the review.
  • CO2 experiment as requested during the review process
  • A Forage example which is currently disabled - due to replacements not working with forage examples as discussed during the Canola review. It can be enabled when the model is released.
  • RowConfiguration example to show skip row handling.

I will add a location example to that file as well.

@hol353
Copy link
Contributor

hol353 commented Aug 19, 2022

Thanks @jbrider I didn't see the separate SorghumPlausibilityRuns .apsimx file. A lot of work has gone into it which is great! Well done. Add a location example to it and I'll move the files from UnderReview to the validation directory and merge this PR.

@jbrider
Copy link
Contributor Author

jbrider commented Aug 25, 2022

@hol353 This is right to merge.

@hol353
Copy link
Contributor

hol353 commented Aug 28, 2022

retest this please jenkins

1 similar comment
@hol353
Copy link
Contributor

hol353 commented Aug 28, 2022

retest this please jenkins

@hol353 hol353 merged commit 5ed3f61 into APSIMInitiative:master Aug 28, 2022
@hol353
Copy link
Contributor

hol353 commented Aug 28, 2022

Sorghum is released. Well done @jbrider and the sorghum team!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants