Do not allow keeping the ICC when converting from RGB to gray #2669
+50
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrabaud
changed the title
vrabaud
force-pushed
the
icc_gray
branch
2 times, most recently
from
15fa390 to
b08700a
Compare
maryla-uc
approved these changes
Mar 5, 2025
There was a problem hiding this comment.
This sounds like a fairly cryptic error message for a user to get, especially since they didn't explicitly "ask to keep" the icc profile, it's just the default behavior (I think?). Mentioning the flags would be clearer but in that case it would be better to do it in avifenc.c directly...
Something like
"The image contains an RGB ICC profile which is incompatible with the requested output format YUV400 (grayscale). Pass --ignore-icc to discard the ICC profile."
|
Indeed, this API is internal and only used by tests and exposed in avifenc. I changed the message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #2639