Specify target platform version in binary artifacts (#2652)

AOMediaCodec · Mar 7, 2025 · 3e305e7 · 3e305e7
1 parent ad49114
commit 3e305e7
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/.github/workflows/ci-macos-artifacts.yml b/.github/workflows/ci-macos-artifacts.yml
@@ -34,6 +34,7 @@ jobs:
           -DAVIF_BUILD_EXAMPLES=OFF -DAVIF_BUILD_APPS=ON
           -DAVIF_BUILD_TESTS=OFF -DAVIF_ENABLE_WERROR=ON
           -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++
+          -DCMAKE_OSX_DEPLOYMENT_TARGET=11
       - name: Build libavif (ninja)
         working-directory: ./build
         run: ninja

diff --git a/.github/workflows/ci-windows-artifacts.yml b/.github/workflows/ci-windows-artifacts.yml
@@ -56,23 +56,23 @@ jobs:
 
       - name: Prepare libavif (cmake)
         run: >
-          cmake -G Ninja -S . -B build
+          cmake -G "Visual Studio 17 2022" -A x64 -S . -B build
           -DCMAKE_BUILD_TYPE=Release -DBUILD_SHARED_LIBS=OFF
           -DAVIF_CODEC_AOM=LOCAL -DAVIF_CODEC_AOM_ENCODE=ON
           -DAVIF_CODEC_AOM_DECODE=OFF -DAVIF_CODEC_DAV1D=LOCAL
           -DAVIF_LIBYUV=LOCAL -DAVIF_LIBSHARPYUV=LOCAL
           -DAVIF_JPEG=LOCAL -DAVIF_ZLIBPNG=LOCAL
           -DAVIF_BUILD_EXAMPLES=OFF -DAVIF_BUILD_APPS=ON
           -DAVIF_BUILD_TESTS=OFF -DAVIF_ENABLE_WERROR=ON
-      - name: Build libavif (ninja)
-        working-directory: ./build
-        run: ninja
+          -DCMAKE_VS_WINDOWS_TARGET_PLATFORM_VERSION=10
+      - name: Build libavif
+        run: cmake --build build --config=Release --parallel 4
       - name: Archive artifacts
         uses: thedoctor0/zip-release@b57d897cb5d60cb78b51a507f63fa184cfe35554 # 0.7.6
         with:
           type: "zip"
           filename: "windows-artifacts.zip"
-          directory: "build"
+          directory: "build/Release"
           path: "*.exe"
       - name: Upload artifacts
         uses: actions/upload-release-asset@e8f9f06c4b078e705bd2ea027f0926603fc9b4d5 # v1.0.2
@@ -81,7 +81,7 @@ jobs:
         with:
           # See https://docs.github.com/en/webhooks/webhook-events-and-payloads#release.
           upload_url: ${{ github.event.release.upload_url }}
-          asset_path: build/windows-artifacts.zip
+          asset_path: build/Release/windows-artifacts.zip
           asset_name: windows-artifacts.zip
           asset_content_type: application/zip
 
@@ -90,4 +90,4 @@ jobs:
     #   uses: actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874 # v4.4.0
     #   with:
     #     name: windows-artifacts.zip
-    #     path: build/windows-artifacts.zip
+    #     path: build/Release/windows-artifacts.zip