-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MuonFitter RNNFit model scripts #290
Conversation
OK.... so. Step 1. is to run Step 2. is to run Step 3. is There also appears to be a We also have Finally the rnn_fit.sh is hard-coding Sorry to give you a bunch of extra work, but this is kind of a mess. 😑 I'm not going to ask you to do it (i'm asking enough already), but these scripts could be converted to python Tools without too much work (mostly just copy-paste into the python tool template and update getting the configuration variables), then each of the steps could be chained together into a single ToolChain. Paths of inputs/outputs could even be passed via the datamodel, or hell, they could even pass data via the datamodel and do away with the intermediate files.... 🤯 |
Steps 1 and 2 are used to generate model files, which already exist in For step 3, that follows instructions starting at line 44 from To my understanding, For I'll update all the README files accordingly and make sure they are as present as possible. I'll also double check the necessity of |
…. Also changed location of MuonFitter README from MuonFitter/RNNFit/ to MuonFitter/
OK, sounds good. Please do chase up Julie to find out more details on the inputs to training the model. While we have models that run, without knowing details of the training process the generated results may have caveats that we aren't aware of, or generally may just give poor performance (e.g., if they've been trained on WCSim simulations and QE / reflectivity values have changed, the model may need re-training to account for that). |
Collection of scripts to create and use models necessary for MuonFitter. Should these be located in ToolAnalysis or stored on the gpvms? Also, some of these scripts require "torch" as a python package which is not available in the current containers. Julie and I have currently used these scripts on our personal machines. I would like to integrate them into the central ANNIE framework if possible.