Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparation for deprecation of __AMDGCN_WAVEFRONT_SIZE #4311

Merged
merged 1 commit into from
Feb 3, 2025
+8 −4
Merged

Preparation for deprecation of __AMDGCN_WAVEFRONT_SIZE #4311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Docs/sphinx_documentation/source/Basics.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -704,7 +704,7 @@ reading from command line or input file.

Because many AMReX classes and functions (including destructors
inserted by the compiler) do not function properly after
:cpp:`amrex:Finalize` is called, it's best to put the codes between
:cpp:`amrex::Finalize` is called, it's best to put the codes between
:cpp:`amrex::Initialize` and :cpp:`amrex::Finalize` into its scope
(e.g., a pair of curly braces or a separate function) to make sure
resources are properly freed.
Expand Down
10 changes: 7 additions & 3 deletions Src/Base/AMReX_GpuDevice.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,11 +65,15 @@ namespace {
namespace {
__host__ __device__ void amrex_check_wavefront_size () {
#ifdef __HIP_DEVICE_COMPILE__
// https://github.com/AMReX-Codes/amrex/issues/3792
// __AMDGCN_WAVEFRONT_SIZE is valid in device code only.
// Thus we have to check it this way.
// * https://github.com/AMReX-Codes/amrex/issues/3792
// __AMDGCN_WAVEFRONT_SIZE is valid in device code only.
// Thus we have to check it this way.
// * https://github.com/AMReX-Codes/amrex/issues/4270
// __AMDGCN_WAVEFRONT_SIZE will be deprecated.
#ifdef __AMDGCN_WAVEFRONT_SIZE
static_assert(__AMDGCN_WAVEFRONT_SIZE == AMREX_AMDGCN_WAVEFRONT_SIZE,
"Please let the amrex team know if you encounter this");
#endif
#endif
}
}
Expand Down
Loading