Skip to content

Commit

Permalink
feat: fix tests
Browse files Browse the repository at this point in the history
  • Loading branch information
amirai21 committed Dec 4, 2024
1 parent 46ba724 commit 50a98fa
Show file tree
Hide file tree
Showing 17 changed files with 40 additions and 27 deletions.
2 changes: 1 addition & 1 deletion examples/studio/conversational-rag/rag-engine.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { AI21 } from 'ai21';
import { FileResponse, UploadFileResponse } from '../../../src/types/rag';
import { FileResponse, UploadFileResponse } from '../../../src/types';
import path from 'path';

function sleep(ms) {
Expand Down
2 changes: 1 addition & 1 deletion src/APIClient.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@ import {
Headers,
CrossPlatformResponse,
UnifiedFormData,
FilePathOrFileObject,
} from './types';
import { AI21EnvConfig } from './EnvConfig';
import { createFetchInstance, createFilesHandlerInstance } from './runtime';
import { Fetch } from 'fetch';
import { FilePathOrFileObject } from 'types/rag';
import { BaseFilesHandler } from 'files/BaseFilesHandler';

const validatePositiveInteger = (name: string, n: unknown): number => {
Expand Down
2 changes: 1 addition & 1 deletion src/files/BaseFilesHandler.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { FilePathOrFileObject } from 'types';
import { FormDataRequest } from 'types/API';
import { FilePathOrFileObject } from 'types/rag';

export abstract class BaseFilesHandler {
abstract prepareFormDataRequest(file: FilePathOrFileObject): Promise<FormDataRequest>;
Expand Down
2 changes: 1 addition & 1 deletion src/files/BrowserFilesHandler.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { FilePathOrFileObject } from 'types/rag';
import { FilePathOrFileObject } from 'types';
import { BaseFilesHandler } from './BaseFilesHandler';
import { FormDataRequest } from 'types/API';

Expand Down
2 changes: 1 addition & 1 deletion src/files/NodeFilesHandler.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { FilePathOrFileObject } from 'types/rag';
import { FilePathOrFileObject } from 'types';
import { BaseFilesHandler } from './BaseFilesHandler';
import { FormDataRequest } from 'types/API';

Expand Down
4 changes: 2 additions & 2 deletions src/resources/rag/conversationalRag.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import * as Models from '../../types';
import { APIResource } from '../../APIResource';
import { ConversationalRagRequest } from '../../types/rag/ConversationalRagRequest';
import { ConversationalRagResponse } from '../../types/rag/ConversationalRagResponse';
import { ConversationalRagRequest } from '../../types';
import { ConversationalRagResponse } from '../../types';

export class ConversationalRag extends APIResource {
create(body: ConversationalRagRequest, options?: Models.RequestOptions) {
Expand Down
4 changes: 2 additions & 2 deletions src/resources/rag/files.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import * as Models from '../../types';
import { APIResource } from '../../APIResource';
import { UploadFileResponse, UploadFileRequest, ListFilesFilters, UpdateFileRequest } from '../../types/rag';
import { FileResponse } from 'types/rag/FileResponse';
import { UploadFileResponse, UploadFileRequest, ListFilesFilters, UpdateFileRequest } from '../../types';
import { FileResponse } from 'types/files/FileResponse';

const FILES_PATH = '/library/files';

Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
11 changes: 11 additions & 0 deletions src/types/files/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
export { type UploadFileRequest } from './UploadFileRequest';

export { type FileResponse } from './FileResponse';

export { type UploadFileResponse } from './UploadFileResponse';

export { type ListFilesFilters } from './ListFilesFilters';

export { type UpdateFileRequest } from './UpdateFileRequest';

export { type FilePathOrFileObject } from './FilePathOrFileObject';
9 changes: 9 additions & 0 deletions src/types/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,3 +44,12 @@ export {
type ConversationalRagSource,
type RetrievalStrategy,
} from './rag';

export {
type UploadFileRequest,
type UploadFileResponse,
type FileResponse,
type ListFilesFilters,
type UpdateFileRequest,
type FilePathOrFileObject,
} from './files';
12 changes: 0 additions & 12 deletions src/types/rag/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,3 @@ export { type ConversationalRagSource } from './ConversationalRagSource';
export { type ConversationalRagResponse } from './ConversationalRagResponse';

export { type RetrievalStrategy } from './RetrievalStrategy';

export { type UploadFileRequest } from './UploadFileRequest';

export { type FileResponse } from './FileResponse';

export { type UploadFileResponse } from './UploadFileResponse';

export { type ListFilesFilters } from './ListFilesFilters';

export { type UpdateFileRequest } from './UpdateFileRequest';

export { type FilePathOrFileObject } from './FilePathOrFileObject';
17 changes: 11 additions & 6 deletions tests/unittests/resources/rag-engine.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ describe('RAGEngine', () => {

it('should upload a file and return the fileId', async () => {
const fileInput = 'path/to/file.txt';
const body = { file: fileInput, path: 'label' };
const body = { file: fileInput, path: 'path' };
const expectedResponse = { fileId: '12345' };

mockClient.upload.mockResolvedValue(expectedResponse);
Expand All @@ -41,7 +41,9 @@ describe('RAGEngine', () => {
expect(mockClient.upload).toHaveBeenCalledWith(
'/library/files',
fileInput,
{ body, headers: { 'Authorization': `Bearer ${dummyAPIKey}` } }
{
body: { path: 'path' },
}
);
expect(response).toEqual(expectedResponse);
});
Expand All @@ -56,7 +58,7 @@ describe('RAGEngine', () => {

expect(mockClient.get).toHaveBeenCalledWith(
`/library/files/${fileId}`,
{ headers: { 'Authorization': `Bearer ${dummyAPIKey}` } }
{ ...options }
);
expect(response).toEqual(expectedResponse);
});
Expand All @@ -70,7 +72,7 @@ describe('RAGEngine', () => {

expect(mockClient.delete).toHaveBeenCalledWith(
`/library/files/${fileId}`,
{ headers: { 'Authorization': `Bearer ${dummyAPIKey}` } }
{ ...options }
);
expect(response).toBeNull();
});
Expand All @@ -85,7 +87,7 @@ describe('RAGEngine', () => {

expect(mockClient.put).toHaveBeenCalledWith(
`/library/files/${fileId}`,
{ body, headers: { 'Authorization': `Bearer ${dummyAPIKey}` } }
{ body },
);
expect(response).toBeNull();
});
Expand All @@ -100,7 +102,10 @@ describe('RAGEngine', () => {

expect(mockClient.get).toHaveBeenCalledWith(
'/library/files',
{ query: filters, headers: { 'Authorization': `Bearer ${dummyAPIKey}` } }
{
query: filters,
headers: { 'Authorization': `Bearer ${dummyAPIKey}` }
}
);
expect(response).toEqual(expectedResponse);
});
Expand Down

0 comments on commit 50a98fa

Please sign in to comment.