Add receiver, fix get_alerts filtering #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `receiver` as an acceptable query parameter for `get_alerts()`. Receiver is a valid parameter as shown in the [openapi spec](https://github.com/prometheus/alertmanager/blob/e1492602209b86e0ca6d7671c7353b62a31b897b/api/v2/openapi.yaml#L171)
partcyborg
changed the title
jpavlav
approved these changes
Sep 30, 2024
|
Thanks @jpavlav for the prompt response! Are there any plans to release a new package with recent changes to pypy? |
|
Oh sure. I'll see if I can get to it today. Thanks for the contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
receiveras an acceptable query parameter forget_alerts().Receiver is a valid parameter as shown in the openapi spec
Also, fix the filter generation for the v2 api. In the V2 API, each
<key>="<val>"parameter is passed as an individualfilterget parameter, not as a comma separated string