Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Windows support #12

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marcelotrevisani
Copy link

as the user of the other PR is unresponsive I am creating this PR, I did some small modifications
and I am put him as a co-author of the commit as well

Copy link

⚠️ This PR contains unsigned commits. To get your PR merged, please sign those commits (git rebase --exec 'git commit -S --amend --no-edit -n' @{upstream}) and force push them to this branch (git push --force-with-lease).

If you're new to commit signing, there are different ways to set it up:

Sign commits with gpg

Follow the steps below to set up commit signing with gpg:

  1. Generate a GPG key
  2. Add the GPG key to your GitHub account
  3. Configure git to use your GPG key for commit signing
Sign commits with ssh-agent

Follow the steps below to set up commit signing with ssh-agent:

  1. Generate an SSH key and add it to ssh-agent
  2. Add the SSH key to your GitHub account
  3. Configure git to use your SSH key for commit signing
Sign commits with 1Password

You can also sign commits using 1Password, which lets you sign commits with biometrics without the signing key leaving the local 1Password process.

Learn how to use 1Password to sign your commits.

Watch the demo

Co-authored-by: sszzsolt <sszzsolt@users.noreply.github.com>
@marcelotrevisani
Copy link
Author

if you could take a look @edif2008 please

@marcelotrevisani
Copy link
Author

Commits are signed

@AndyTitu
Copy link

AndyTitu commented Feb 13, 2025

@marcelotrevisani I wonder if the logic from install-cli.ps1 could be simplified by downloading the CLI from winget? We automatically update WinGet with each cli version we release (for stable only). Maybe if we use a winget-cli download action, we could then simply do winget install 1password-cli

@marcelotrevisani
Copy link
Author

Hi,
I might be wrong but I think winget is not available by default in the windows GitHub runners. And this current solution is more generic. That would simplify the logic but will add a new step to guarantee that winget is installed. Because self hosted runners might not have it as well

@marcelotrevisani
Copy link
Author

Gentle ping @AndyTitu

@marcelotrevisani
Copy link
Author

Sorry for pinging but that is blocking us to use 1password with gh actions and we dont want to have one setup for windows and another for unix-like OS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants