Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Clean codes #182

Merged
merged 7 commits into from
Feb 22, 2025
Merged

refactor: Clean codes #182

merged 7 commits into from
Feb 22, 2025

Conversation

134130
Copy link
Owner

@134130 134130 commented Feb 22, 2025

Refactoring and improvements:

  • MiseTask with more specific task classes
  • Removing redundant utilities
  • Add task tests
  • Support task_config toml tests

@134130 134130 self-assigned this Feb 22, 2025
@134130 134130 marked this pull request as ready for review February 22, 2025 09:39
@134130 134130 enabled auto-merge (squash) February 22, 2025 09:48
@134130 134130 merged commit cdba1c5 into main Feb 22, 2025
3 checks passed
@134130 134130 deleted the cooper/refactor-2 branch February 22, 2025 09:51
Copy link
Contributor

Qodana Community for JVM

49 new problems were found

Inspection name Severity Problems
Unused symbol 🔶 Warning 19
Constructor parameter is never used as a property 🔶 Warning 4
Redundant nullable return type 🔶 Warning 2
Usage of redundant or deprecated syntax or deprecated symbols 🔶 Warning 1
Unstable API Usage 🔶 Warning 1
Class member can have 'private' visibility ◽️ Notice 9
Function or property has platform type ◽️ Notice 7
Unnecessary type argument ◽️ Notice 5
Nested lambda has shadowed implicit parameter ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2024.3.4
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant