Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove Internaled API: AbstractMessage #170

Merged
merged 1 commit into from
Feb 9, 2025
Merged

fix: Remove Internaled API: AbstractMessage #170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions modules/core/src/main/kotlin/com/github/l34130/mise/core/MiseErrorReportSubmitter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@

import com.github.l34130.mise.core.command.MiseCommandLine
import com.github.l34130.mise.core.notification.MiseNotificationService
import com.intellij.diagnostic.AbstractMessage
import com.intellij.diagnostic.LogMessage
import com.intellij.diagnostic.PluginException
import com.intellij.ide.DataManager
import com.intellij.openapi.actionSystem.CommonDataKeys
Expand Down Expand Up @@ -44,12 +42,8 @@
for (event in events) {
var throwable = event.throwable
val description = additionalInfo ?: ""
var attachments = listOf<Attachment>()

Check warning on line 45 in modules/core/src/main/kotlin/com/github/l34130/mise/core/MiseErrorReportSubmitter.kt

View workflow job for this annotation

GitHub Actions / Qodana Community for JVM

Local 'var' is never modified and can be declared as 'val' 

Variable is never modified, so it can be declared using 'val'

if (event.data is LogMessage) {
throwable = (event.data as AbstractMessage).throwable
attachments = (event.data as AbstractMessage).includedAttachments
}
if (throwable is PluginException && throwable.cause != null) {
// unwrap PluginManagerCore.createPluginException
throwable = throwable.cause
Expand Down Expand Up @@ -84,7 +78,7 @@
appendLine()

appendLine("### Attachments")
for (attachment in attachments) {

Check warning on line 81 in modules/core/src/main/kotlin/com/github/l34130/mise/core/MiseErrorReportSubmitter.kt

View workflow job for this annotation

GitHub Actions / Qodana Community for JVM

Constant conditions 

'for' range is always empty
appendLine("- $attachment")
}
}
Expand Down
Loading