Fixed Implicitly marking parameter $woocommerce as nullable is deprecated warning with PHP 8.4 #4087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This explicitly allows for WooCommerce to be nullable. I manually tested this fix with PHP 8.1 > 8.4 Fixes 10up#4086 see: https://www.php.net/manual/en/migration84.deprecated.php
Ensure PHP 7.4 support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Updates
OrdersAutosuggest.phpto allow$woocommeceto be nullable explicitly.I manually tested this fix with PHP 8.1 > 8.4
Closes #4086
How to test the Change
Update to PHP 8.4 to receive the error, then apply the change and it should go away.
It would be good to test this change with WooCommerce installed
Changelog Entry
Credits
Props @BrookeDot
Checklist: