Fixed Carlos review #411
Open
Fixed Carlos review #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignasirv
requested review from
invocamanman,
krlosMata and
laisolizq
as code owners
ignasirv
force-pushed
the
feature/carlos-review-1
branch
from
09071a3 to
bd809aa
Compare
ignasirv
force-pushed
the
feature/carlos-review-1
branch
from
bd809aa to
255af03
Compare
ignasirv
force-pushed
the
feature/ongoing-v0.3.0
branch
from
3659d96 to
e505edf
Compare
ignasirv
force-pushed
the
feature/carlos-review-1
branch
2 times, most recently
from
5e6c1c6 to
088af5b
Compare
ignasirv
force-pushed
the
feature/carlos-review-1
branch
from
9e23741 to
9c60808
Compare
Install toolbox packages separately
ignasirv
force-pushed
the
feature/carlos-review-1
branch
3 times, most recently
from
5539f7d to
588679f
Compare
ignasirv
force-pushed
the
feature/carlos-review-1
branch
from
588679f to
1f0b3d6
Compare
ignasirv
force-pushed
the
feature/carlos-review-1
branch
from
3dc8eb3 to
16b8904
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed from Carlos review issues:
https://github.com/orgs/0xPolygonHermez/projects/19/views/1?pane=issue&itemId=99101469&issue=0xPolygonHermez%7Cinternal-audit%7C93
https://github.com/orgs/0xPolygonHermez/projects/19/views/1?pane=issue&itemId=99109405&issue=0xPolygonHermez%7Cinternal-audit%7C94
https://github.com/orgs/0xPolygonHermez/projects/19/views/1?pane=issue&itemId=99120921&issue=0xPolygonHermez%7Cinternal-audit%7C95
createNewRollupfunction toattachAggchainToAL