refactor: use clippy pedantic

Author: ymgyt

Cargo.toml

@@ -7,6 +7,7 @@ authors     = ["ymgyt"]
 categories  = ["command-line-utilities"]
 description = "terminal feed viewer"
 edition     = "2021"
+keywords    = ["feed", "rss", "atom", "tui"]
 license     = "MIT OR Apache-2.0"
 readme      = "README"
 repository  = "https://github.com/ymgyt/syndicationd"
@@ -29,3 +30,23 @@ tokio              = { version = "1.35" }
 tracing            = { version = "0.1.40" }
 tracing-subscriber = { version = "0.3.18", features = ["smallvec", "fmt", "ansi", "std", "env-filter", "time"], default-features = false }
 url                = { version = "2.5.0" }
+
+[workspace.lints.rust]
+unsafe_code = "forbid"
+
+[workspace.lints.clippy]
+
+# cargo
+cargo_common_metadata   = "warn"
+multiple_crate_versions = "allow"
+negative_feature_names  = "warn"
+redundant_feature_names = "warn"
+wildcard_dependencies   = "warn"
+
+# pedantic
+pedantic = "warn"
+
+missing_errors_doc      = "allow"
+missing_panics_doc      = "allow"
+module_name_repetitions = "allow"
+must_use_candidate      = "allow"

clippy.toml

@@ -0,0 +1,3 @@
+# not landed yet
+# https://github.com/rust-lang/rust-clippy/issues/12164#issuecomment-1909934040
+# allowed-duplicate-crates = []

crates/synd_api/Cargo.toml

@@ -1,12 +1,15 @@
 [package]
 authors.workspace    = true
 categories.workspace = true
-description          = "syndicationd backend api"
 edition.workspace    = true
+keywords.workspace   = true
 license.workspace    = true
-name                 = "synd_api"
+readme.workspace     = true
 repository.workspace = true
-version              = "0.1.0"
+
+description = "syndicationd backend api"
+name        = "synd_api"
+version     = "0.1.0"
 
 [dependencies]
 anyhow = { workspace = true }
@@ -40,3 +43,6 @@ tracing-subscriber = { workspace = true }
 
 # Enable graphql introspection
 introspection = []
+
+[lints]
+workspace = true

crates/synd_api/src/client/github/client.rs

@@ -14,7 +14,7 @@ pub struct GithubClient {
 impl GithubClient {
     const ENDPOINT: &'static str = "https://api.github.com/graphql";
 
-    /// Construct GithubClient.
+    /// Construct `GithubClient`.
     pub fn new() -> anyhow::Result<Self> {
         let client = reqwest::ClientBuilder::new()
             .user_agent(config::USER_AGENT)
@@ -27,10 +27,11 @@ impl GithubClient {
 
     pub async fn authenticate(&self, access_token: &str) -> anyhow::Result<String> {
         let variables = query::authenticate::Variables {};
-        let req = query::Authenticate::build_query(variables);
-        let res: query::authenticate::ResponseData = self.request(access_token, &req).await?;
+        let request = query::Authenticate::build_query(variables);
+        let response: query::authenticate::ResponseData =
+            self.request(access_token, &request).await?;
 
-        Ok(res.viewer.email)
+        Ok(response.viewer.email)
     }
 
     async fn request<Body, ResponseData>(
@@ -42,7 +43,7 @@ impl GithubClient {
         Body: Serialize + ?Sized,
         ResponseData: DeserializeOwned + Debug,
     {
-        let mut auth_header = HeaderValue::try_from(format!("bearer {}", access_token))?;
+        let mut auth_header = HeaderValue::try_from(format!("bearer {access_token}"))?;
         auth_header.set_sensitive(true);
 
         let res: Response<ResponseData> = self

crates/synd_api/src/gql/object/mod.rs

@@ -96,7 +96,7 @@ impl Feed {
 
     /// Undering feed specification
     async fn r#type(&self) -> FeedType {
-        self.0.meta().r#type().into()
+        self.0.meta().r#type().clone().into()
     }
 
     /// Feed title
@@ -115,6 +115,7 @@ impl Feed {
     }
 
     /// Feed entries
+    #[allow(clippy::cast_sign_loss)]
     async fn entries(
         &self,
         #[graphql(default = 5)] first: Option<i32>,
@@ -126,6 +127,7 @@ impl Feed {
         FeedEntryConnectionName,
         FeedEntryEdgeName,
     > {
+        #[allow(clippy::cast_sign_loss)]
         let first = first.unwrap_or(5).max(0) as usize;
         let meta = self.0.meta();
         let entries = self

crates/synd_api/src/gql/query.rs

@@ -25,6 +25,7 @@ impl Subscription {
         after: Option<String>,
         #[graphql(default = 20)] first: Option<i32>,
     ) -> Result<Connection<String, object::Feed>> {
+        #[allow(clippy::cast_sign_loss)]
         let first = first.unwrap_or(10).min(100) as usize;
         let has_prev = after.is_some();
         let input = FetchSubscribedFeedsInput {
@@ -57,6 +58,7 @@ impl Subscription {
         after: Option<String>,
         #[graphql(default = 20)] first: Option<i32>,
     ) -> Result<Connection<id::EntryId, Entry<'cx>>> {
+        #[allow(clippy::cast_sign_loss)]
         let first = first.unwrap_or(20).min(200) as usize;
         let has_prev = after.is_some();
         let input = FetchEntriesInput {

crates/synd_api/src/persistence/memory.rs

@@ -41,7 +41,7 @@ impl MemoryDatastore {
                     .iter()
                     .map(|feed| persistence::types::FeedSubscription {
                         user_id: "me".into(),
-                        url: feed.to_string(),
+                        url: (*feed).to_string(),
                     })
                     .collect(),
             ),

crates/synd_api/src/principal.rs

@@ -30,7 +30,7 @@ impl User {
 
         email.hash(&mut s);
         let id = s.finish();
-        let id = format!("{:016x}", id);
+        let id = format!("{id:016x}");
 
         User { id, email }
     }

crates/synd_api/src/serve/layer/audit.rs

@@ -48,14 +48,16 @@ impl Audit {
     pub const OPERATION: &'static str = "operation";
     pub const RESULT: &'static str = "result";
 
+    /// # Panics
+    /// panic when directive is invalid
     pub fn directive() -> Directive {
         let directive = format!("{emit}=info", emit = Self::EMIT_TARGET);
 
         directive.parse().expect("Invalid directive")
     }
 }
 
-/// Create AuditLayer
+/// Create `AuditLayer`
 pub fn layer<S>() -> impl Layer<S>
 where
     S: Subscriber + for<'span> LookupSpan<'span>,
@@ -72,18 +74,18 @@ impl AuditFilter {
         Self {}
     }
 
-    fn is_enabled(&self, meta: &Metadata<'_>) -> bool {
+    fn is_enabled(meta: &Metadata<'_>) -> bool {
         meta.target() == Audit::TARGET
     }
 }
 
 impl<S> layer::Filter<S> for AuditFilter {
     fn enabled(&self, meta: &Metadata<'_>, _cx: &Context<'_, S>) -> bool {
-        self.is_enabled(meta)
+        Self::is_enabled(meta)
     }
 
     fn callsite_enabled(&self, meta: &'static Metadata<'static>) -> Interest {
-        if self.is_enabled(meta) {
+        if Self::is_enabled(meta) {
             Interest::always()
         } else {
             Interest::never()
@@ -138,7 +140,7 @@ impl<S> Layer<S> for AuditLayer
 where
     S: Subscriber + for<'span> LookupSpan<'span>,
 {
-    /// If new span is audit root span, create AuditContext and insert to extensions.
+    /// If new span is audit root span, create `AuditContext` and insert to extensions.
     fn on_new_span(&self, attrs: &Attributes<'_>, id: &span::Id, ctx: Context<'_, S>) {
         if attrs.metadata().name() != Audit::SPAN_ROOT_NAME {
             return;

crates/synd_api/src/serve/layer/authenticate/mod.rs

@@ -70,7 +70,7 @@ where
                     self.set(AuthenticateFuture::ServiceCall { service_fut });
                     self.poll(cx)
                 }
-                Poll::Ready(Err(_)) => Poll::Ready(Ok(StatusCode::UNAUTHORIZED.into_response())),
+                Poll::Ready(Err(())) => Poll::Ready(Ok(StatusCode::UNAUTHORIZED.into_response())),
                 Poll::Pending => Poll::Pending,
             },
             AuthFutureProj::ServiceCall { service_fut } => service_fut.poll(cx),

crates/synd_api/src/usecase/fetch_subscribed_feeds.rs

@@ -76,13 +76,13 @@ impl Usecase for FetchSubscribedFeeds {
         let feeds = self.fetch_feed.fetch_feeds_parallel(urls).await;
 
         // TODO: return failed feeds
-        let (feeds, errors): (Vec<_>, Vec<_>) = feeds.into_iter().partition(|r| r.is_ok());
+        let (feeds, errors): (Vec<_>, Vec<_>) = feeds.into_iter().partition(Result::is_ok);
 
         if !errors.is_empty() {
             tracing::error!("{errors:?}");
         }
 
-        let feeds = feeds.into_iter().map(|r| r.unwrap()).collect();
+        let feeds = feeds.into_iter().map(Result::unwrap).collect();
 
         Ok(Output {
             output: FetchSubscribedFeedsOutput { feeds },

crates/synd_authn/Cargo.toml

@@ -1,13 +1,15 @@
 [package]
-authors.workspace     = true
-categories.workspace  = true
-description.workspace = true
-edition.workspace     = true
-license.workspace     = true
-name                  = "synd_authn"
-readme.workspace      = true
-repository.workspace  = true
-version               = "0.1.0"
+authors.workspace    = true
+categories.workspace = true
+edition.workspace    = true
+keywords.workspace   = true
+license.workspace    = true
+readme.workspace     = true
+repository.workspace = true
+
+description = "syndicationd authentication lib"
+name        = "synd_authn"
+version     = "0.1.0"
 
 [dependencies]
 anyhow         = { workspace = true }
@@ -18,3 +20,6 @@ serde          = { workspace = true, features = ["derive"] }
 serde_json     = { workspace = true }
 tokio          = { workspace = true, features = ["time"] }
 tracing        = { workspace = true }
+
+[lints]
+workspace = true

crates/synd_authn/src/device_flow/github.rs

@@ -11,7 +11,7 @@ use crate::device_flow::{
 
 const USER_AGENT: &str = concat!(env!("CARGO_PKG_NAME"), "/", env!("CARGO_PKG_VERSION"));
 
-/// https://docs.github.com/en/apps/oauth-apps/building-oauth-apps/authorizing-oauth-apps#device-flow
+/// <https://docs.github.com/en/apps/oauth-apps/building-oauth-apps/authorizing-oauth-apps#device-flow>
 #[derive(Clone)]
 pub struct DeviceFlow {
     client: Client,
@@ -37,6 +37,7 @@ impl DeviceFlow {
         }
     }
 
+    #[must_use]
     pub fn with_endpoint(self, endpoint: &'static str) -> Self {
         Self {
             endpoint: Some(endpoint),
@@ -110,14 +111,15 @@ impl DeviceFlow {
             match response.status() {
                 StatusCode::OK => {
                     let full = response.bytes().await?;
-                    match serde_json::from_slice::<DeviceAccessTokenResponse>(&full) {
-                        Ok(response) => break response,
-                        Err(_) => continue_or_abort!(full),
+                    if let Ok(response) = serde_json::from_slice::<DeviceAccessTokenResponse>(&full)
+                    {
+                        break response;
                     }
+                    continue_or_abort!(full);
                 }
                 StatusCode::BAD_REQUEST => {
                     let full = response.bytes().await?;
-                    continue_or_abort!(full)
+                    continue_or_abort!(full);
                 }
                 other => {
                     let error_msg = response.text().await.unwrap_or_default();

crates/synd_authn/src/device_flow/mod.rs

@@ -5,14 +5,14 @@ use serde::{Deserialize, Serialize};
 
 pub mod github;
 
-/// https://datatracker.ietf.org/doc/html/rfc8628#section-3.1
+/// <https://datatracker.ietf.org/doc/html/rfc8628#section-3.1>
 #[derive(Serialize, Deserialize, Debug)]
 pub struct DeviceAuthorizationRequest<'s> {
     pub client_id: Cow<'s, str>,
     pub scope: Cow<'s, str>,
 }
 
-/// https://datatracker.ietf.org/doc/html/rfc8628#section-3.2
+/// <https://datatracker.ietf.org/doc/html/rfc8628#section-3.2>
 #[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
 pub struct DeviceAuthorizationResponse {
     /// device verification code
@@ -57,7 +57,7 @@ impl<'s> DeviceAccessTokenRequest<'s> {
 }
 
 /// Successful Response
-/// https://datatracker.ietf.org/doc/html/rfc6749#section-5.1
+/// <https://datatracker.ietf.org/doc/html/rfc6749#section-5.1>
 #[derive(Deserialize, Debug)]
 pub struct DeviceAccessTokenResponse {
     /// the access token issued by the authorization server
@@ -67,7 +67,7 @@ pub struct DeviceAccessTokenResponse {
     pub expires_in: Option<i64>,
 }
 
-/// https://datatracker.ietf.org/doc/html/rfc6749#section-5.2
+/// <https://datatracker.ietf.org/doc/html/rfc6749#section-5.2>
 #[derive(Deserialize, Debug)]
 pub struct DeviceAccessTokenErrorResponse {
     pub error: DeviceAccessTokenErrorCode,
@@ -96,9 +96,9 @@ pub enum DeviceAccessTokenErrorCode {
 }
 
 impl DeviceAccessTokenErrorCode {
-    ///  The "authorization_pending" and "slow_down" error codes define particularly unique behavior, as they indicate that the OAuth client should continue to poll the token endpoint by repeating the token request (implementing the precise behavior defined above)
+    ///  The `authorization_pending` and `slow_down` error codes define particularly unique behavior, as they indicate that the OAuth client should continue to poll the token endpoint by repeating the token request (implementing the precise behavior defined above)
     pub fn should_continue_to_poll(&self) -> bool {
-        use DeviceAccessTokenErrorCode::*;
+        use DeviceAccessTokenErrorCode::{AuthorizationPending, SlowDown};
         *self == AuthorizationPending || *self == SlowDown
     }
 }

crates/synd_feed/Cargo.toml

@@ -1,12 +1,15 @@
 [package]
 authors.workspace    = true
 categories.workspace = true
-description          = "Library to handle syndication spec"
 edition.workspace    = true
+keywords.workspace   = true
 license.workspace    = true
-name                 = "synd_feed"
+readme.workspace     = true
 repository.workspace = true
-version              = "0.1.0"
+
+description = "Library to handle syndication spec"
+name        = "synd_feed"
+version     = "0.1.0"
 
 [dependencies]
 anyhow       = { workspace = true }
@@ -19,3 +22,6 @@ reqwest      = { workspace = true, features = ["stream"] }
 thiserror    = "1.0.56"
 tokio        = { workspace = true }
 tracing      = { workspace = true }
+
+[lints]
+workspace = true