Skip to content

Commit 5a2b4fc

Browse files
janselpytorchmergebot
authored andcommitted
[dynamo] Convert invalid args into graph breaks (pytorch#121784)
Pull Request resolved: pytorch#121784 Approved by: https://github.com/yanboliang
1 parent fc33bbf commit 5a2b4fc

File tree

51 files changed

+5
-2
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

51 files changed

+5
-2
lines changed

test/dynamo_expected_failures/TestArrayConstruction.test_array_empty

Whitespace-only changes.

test/dynamo_expected_failures/TestAttributes.test_set_stridesattr

Whitespace-only changes.

test/dynamo_expected_failures/TestAttributes.test_stridesattr

Whitespace-only changes.

test/dynamo_expected_failures/TestBincount.test_with_incorrect_minlength

Whitespace-only changes.

test/dynamo_expected_failures/TestClip.test_simple_int32_inout_casting_unsafe

Whitespace-only changes.

test/dynamo_expected_failures/TestConstant.test_check_constant_float3

Whitespace-only changes.

test/dynamo_expected_failures/TestConstant.test_check_constant_pad_2d

Whitespace-only changes.

test/dynamo_expected_failures/TestConvolutionNN.test_Conv2d_missing_argument

Whitespace-only changes.

test/dynamo_expected_failures/TestHistogram.test_precision

Whitespace-only changes.

test/dynamo_expected_failures/TestHistogram2d.test_all_outliers

Whitespace-only changes.

test/dynamo_expected_failures/TestHistogram2d.test_asym

Whitespace-only changes.

test/dynamo_expected_failures/TestHistogramdd.test_finite_range

Whitespace-only changes.

test/dynamo_expected_failures/TestHistogramdd.test_simple

Whitespace-only changes.

test/dynamo_expected_failures/TestMeshgrid.test_invalid_arguments

Whitespace-only changes.

test/dynamo_expected_failures/TestNativeFunctions.test_optional_floatlist_invalid

Whitespace-only changes.

test/dynamo_expected_failures/TestNativeFunctions.test_optional_intlist_invalid

Whitespace-only changes.

test/dynamo_expected_failures/TestNativeFunctions.test_symintlist_error

Whitespace-only changes.

test/dynamo_expected_failures/TestNativeFunctions.test_symintlist_error_with_overload

Whitespace-only changes.

test/dynamo_expected_failures/TestNativeFunctions.test_vararg_symintlist_error

Whitespace-only changes.

test/dynamo_expected_failures/TestPower.test_modular_power

Whitespace-only changes.

test/dynamo_expected_failures/TestQuantizedEmbeddingOps.test_embedding_bag_2bit

Whitespace-only changes.

test/dynamo_expected_failures/TestQuantizedEmbeddingOps.test_embedding_bag_4bit

Whitespace-only changes.

test/dynamo_expected_failures/TestQuantizedOps.test_avg_pool2d_nhwc

Whitespace-only changes.

test/dynamo_expected_failures/TestQuantizedOps.test_avg_pool3d_nhwc

Whitespace-only changes.

test/dynamo_expected_failures/TestQuantizedOps.test_cat_nhwc

Whitespace-only changes.

test/dynamo_expected_failures/TestQuantizedOps.test_interpolate

Whitespace-only changes.

test/dynamo_expected_failures/TestQuantizedOps.test_interpolate3d

Whitespace-only changes.

test/dynamo_expected_failures/TestQuantizedOps.test_max_pool2d_nhwc

Whitespace-only changes.

test/dynamo_expected_failures/TestQuantizedTensor.test_per_channel_qtensor_to_memory_format

Whitespace-only changes.

test/dynamo_expected_failures/TestQuantizedTensor.test_per_tensor_qtensor_to_memory_format

Whitespace-only changes.

test/dynamo_expected_failures/TestSortAndSelectCPU.test_topk_arguments_cpu

Whitespace-only changes.

test/dynamo_expected_failures/TestStaticQuantizedModule.test_embedding_api

Whitespace-only changes.

test/dynamo_expected_failures/TestStaticQuantizedModule.test_embedding_bag_api

Whitespace-only changes.

test/dynamo_expected_failures/TestTEFuserDynamic.test_gelu

Whitespace-only changes.

test/dynamo_expected_failures/TestTEFuserStatic.test_gelu

Whitespace-only changes.

test/dynamo_expected_failures/TestTensorBoardSummary.test_uint8_image

Whitespace-only changes.

test/dynamo_expected_failures/TestTensorBoardUtils.test_to_HWC

Whitespace-only changes.

test/dynamo_expected_failures/TestTorch.test_contains

Whitespace-only changes.

test/dynamo_expected_failures/TestTorch.test_parsing_double

Whitespace-only changes.

test/dynamo_expected_failures/TestTorch.test_parsing_int64

Whitespace-only changes.

test/onnx/test_fx_to_onnx_with_onnxruntime.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -1255,8 +1255,8 @@ def create_model():
12551255
model_type=pytorch_test_common.TorchModelType.TORCH_EXPORT_EXPORTEDPROGRAM,
12561256
)
12571257
@pytorch_test_common.xfail_dynamic_fx_test(
1258-
error_message=" Failed running call_function <built-in function scaled_dot_product_attention>",
1259-
reason="dynamo does not support it.",
1258+
error_message="NOT_IMPLEMENTED : Could not find an implementation for Trilu(14) node",
1259+
reason="Need to check Trilu node in the ONNX graph",
12601260
model_type=pytorch_test_common.TorchModelType.TORCH_NN_MODULE,
12611261
)
12621262
@pytorch_test_common.xfail_if_model_type_is_not_exportedprogram(

torch/_dynamo/utils.py

+3
Original file line numberDiff line numberDiff line change
@@ -1729,6 +1729,9 @@ def get_fake_value(node, tx, allow_non_graph_fake=False):
17291729
)
17301730
elif isinstance(cause, ValueRangeError):
17311731
raise UserError(UserErrorType.CONSTRAINT_VIOLATION, e.args[0]) from e
1732+
elif isinstance(cause, TypeError) and "argument" in str(cause):
1733+
unimplemented(f"TypeError {node.target}: {cause}")
1734+
17321735
raise TorchRuntimeError(str(e)).with_traceback(e.__traceback__) from None
17331736

17341737
if not allow_non_graph_fake:

0 commit comments

Comments
 (0)