From 985a12d8ffd57d13a070b68572313831b95af793 Mon Sep 17 00:00:00 2001 From: Junhao Liao Date: Sun, 29 Sep 2024 23:16:29 -0400 Subject: [PATCH 1/3] new-log-viewer: Centralize border radius overrides with "radius" property. --- new-log-viewer/src/components/theme.tsx | 44 ++++++++++--------------- 1 file changed, 17 insertions(+), 27 deletions(-) diff --git a/new-log-viewer/src/components/theme.tsx b/new-log-viewer/src/components/theme.tsx index a183c719..827158c7 100644 --- a/new-log-viewer/src/components/theme.tsx +++ b/new-log-viewer/src/components/theme.tsx @@ -37,38 +37,11 @@ const APP_THEME = extendTheme({ }, }, }, - focus: { - default: { - outlineWidth: "3px", - }, - }, - fontFamily: { - body: "var(--ylv-ui-font-family)", - }, components: { - JoyButton: { - styleOverrides: { - root: { - borderRadius: "2px", - }, - }, - }, JoySelect: { defaultProps: { indicator: , }, - styleOverrides: { - root: { - borderRadius: "2px", - }, - }, - }, - JoyInput: { - styleOverrides: { - root: { - borderRadius: "2px", - }, - }, }, JoyFormControl: { styleOverrides: { @@ -83,6 +56,23 @@ const APP_THEME = extendTheme({ }, }, }, + focus: { + default: { + outlineWidth: "3px", + }, + }, + fontFamily: { + body: "var(--ylv-ui-font-family)", + }, + radius: { + /* eslint-disable sort-keys */ + xs: "2px", + sm: "2px", + md: "2px", + lg: "2px", + xl: "2px", + /* eslint-enable sort-keys */ + }, }); export default APP_THEME; From e5186ab43bb7306d2939c509bf88ce4773003e5b Mon Sep 17 00:00:00 2001 From: Junhao Liao Date: Thu, 17 Oct 2024 21:06:18 -0400 Subject: [PATCH 2/3] Correctly override focus outline thickness to 1px. --- new-log-viewer/src/components/theme.tsx | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/new-log-viewer/src/components/theme.tsx b/new-log-viewer/src/components/theme.tsx index 827158c7..92eba213 100644 --- a/new-log-viewer/src/components/theme.tsx +++ b/new-log-viewer/src/components/theme.tsx @@ -57,9 +57,7 @@ const APP_THEME = extendTheme({ }, }, focus: { - default: { - outlineWidth: "3px", - }, + thickness: "1px", }, fontFamily: { body: "var(--ylv-ui-font-family)", From bda18dd23fc205754aeb4f9a0f4477b8b8ede168 Mon Sep 17 00:00:00 2001 From: Junhao Liao Date: Fri, 18 Oct 2024 23:37:41 -0400 Subject: [PATCH 3/3] Remove focus thickness override - Apply suggestions from code review Co-authored-by: Henry8192 <50559854+Henry8192@users.noreply.github.com> --- new-log-viewer/src/components/theme.tsx | 3 --- 1 file changed, 3 deletions(-) diff --git a/new-log-viewer/src/components/theme.tsx b/new-log-viewer/src/components/theme.tsx index 92eba213..26245fe7 100644 --- a/new-log-viewer/src/components/theme.tsx +++ b/new-log-viewer/src/components/theme.tsx @@ -56,9 +56,6 @@ const APP_THEME = extendTheme({ }, }, }, - focus: { - thickness: "1px", - }, fontFamily: { body: "var(--ylv-ui-font-family)", },