Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Rename TypeScript type names to indicate nullability #58

Open
3 tasks
coderabbitai bot opened this issue Feb 8, 2025 · 0 comments
Open
3 tasks

refactor: Rename TypeScript type names to indicate nullability #58

coderabbitai bot opened this issue Feb 8, 2025 · 0 comments
Assignees
@Henry8192

Comments

@coderabbitai
Copy link

coderabbitai bot commented Feb 8, 2025

Context

In PR #42, we discussed renaming TypeScript type names to better indicate their nullability. The change involves:

  1. Renaming FilteredLogEventMapTsType to include "Nullable" in its name for consistency with NullableLogEventIdx
  2. Making similar changes in the yscope-log-viewer repository where these types are also defined

References

Tasks

  • Rename FilteredLogEventMapTsType in clp-ffi-js
  • Update corresponding type name in yscope-log-viewer
  • Update any related documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Henry8192 Henry8192

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Henry8192