Skip to content

Commit f53a656

Browse files
committed
simplify function
Signed-off-by: xinyual <xinyual@amazon.com>
1 parent 9c831ba commit f53a656

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

plugin/src/main/java/org/opensearch/ml/action/models/DeleteModelTransportAction.java

+2-4
Original file line numberDiff line numberDiff line change
@@ -533,18 +533,16 @@ private Boolean searchThroughConfig(Object searchCandidate, String candidateId)
533533

534534
private String formatAgentErrorMessage(SearchHit[] hits) {
535535
boolean isHidden = false;
536+
List<String> agentIds = new ArrayList<>();
536537
for (SearchHit hit : hits) {
537538
Map<String, Object> sourceAsMap = hit.getSourceAsMap();
538539
isHidden = isHidden || Boolean.parseBoolean((String) sourceAsMap.getOrDefault(MLAgent.IS_HIDDEN_FIELD, false));
540+
agentIds.add(hit.getId());
539541
}
540542
if (isHidden) {
541543
return String
542544
.format(Locale.ROOT, "%d agents are still using this model, please delete or update the agents first", hits.length);
543545
}
544-
List<String> agentIds = new ArrayList<>();
545-
for (SearchHit hit : hits) {
546-
agentIds.add(hit.getId());
547-
}
548546
return String
549547
.format(
550548
Locale.ROOT,

0 commit comments

Comments
 (0)