Skip to content

Commit d239c25

Browse files
jngz-esjackiehanyang
authored andcommitted
remove unused exception catch, change RuntimeException to IllegalArgumentException (opensearch-project#34)
1 parent d2179ec commit d239c25

File tree

1 file changed

+3
-13
lines changed
  • ml-algorithms/src/main/java/org/opensearch/ml/engine/clustering

1 file changed

+3
-13
lines changed

ml-algorithms/src/main/java/org/opensearch/ml/engine/clustering/KMeans.java

+3-13
Original file line numberDiff line numberDiff line change
@@ -100,19 +100,13 @@ private void validateParameters() {
100100
@Override
101101
public DataFrame predict(DataFrame dataFrame, Model model) {
102102
if (model == null) {
103-
throw new RuntimeException("No model found for KMeans prediction.");
103+
throw new IllegalArgumentException("No model found for KMeans prediction.");
104104
}
105105

106106
List<Prediction<ClusterID>> predictions;
107107
MutableDataset<ClusterID> predictionDataset = TribuoUtil.generateDataset(dataFrame, new ClusteringFactory(),
108108
"KMeans prediction data from opensearch", TribuoOutputType.CLUSTERID);
109-
KMeansModel kMeansModel = null;
110-
try {
111-
kMeansModel = (KMeansModel) ModelSerDeSer.deserialize(model.getContent());
112-
} catch (Exception e) {
113-
throw new RuntimeException("Failed to deserialize model.", e.getCause());
114-
}
115-
109+
KMeansModel kMeansModel = (KMeansModel) ModelSerDeSer.deserialize(model.getContent());
116110
predictions = kMeansModel.predict(predictionDataset);
117111

118112
List<Map<String, Object>> listClusterID = new ArrayList<>();
@@ -130,11 +124,7 @@ public Model train(DataFrame dataFrame) {
130124
Model model = new Model();
131125
model.setName("KMeans");
132126
model.setVersion(1);
133-
try {
134-
model.setContent(ModelSerDeSer.serialize(kMeansModel));
135-
} catch (Exception e) {
136-
throw new RuntimeException("Failed to serialize model.", e.getCause());
137-
}
127+
model.setContent(ModelSerDeSer.serialize(kMeansModel));
138128

139129
return model;
140130
}

0 commit comments

Comments
 (0)