Skip to content

Commit 33ae470

Browse files
authored
[tests/vxlan]: Convert vnet_vxlan test to Python 3 (sonic-net#12540)
In an effort to move/convert PTF test scripts from Python 2 to 3, this PR converts vnet_vxlan.py. Convert vnet_vxlan.py to Python 3 and move it to py3 directory Update ptf_runner to pass is_python3 flag. What is the motivation for this PR? Move remaining Python 2 PTF script to Python 3. How did you do it? Use 2to3. How did you verify/test it? VXLAN (vnet_vxlan and vnet_route_leak) tests are skipped due to issue sonic-net#8374; However, migrating script to Python 3 does not impact the test case. Any platform specific information? Mellanox, Barefoot Signed-off-by: sagummaraj@microsoft.com
1 parent bb06b33 commit 33ae470

File tree

2 files changed

+17
-15
lines changed

2 files changed

+17
-15
lines changed

ansible/roles/test/files/ptftests/vnet_vxlan.py ansible/roles/test/files/ptftests/py3/vnet_vxlan.py

+13-13
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ def getSrvInfo(self, vnet, ifname=''):
9797

9898
def checkPeer(self, test):
9999
for peers in self.peering:
100-
for key, peer in peers.items():
100+
for key, peer in list(peers.items()):
101101
if test['name'] == key:
102102
ptest = dict(test)
103103
ptest['name'] = peer
@@ -109,7 +109,7 @@ def checkPeer(self, test):
109109

110110
def checklocal(self, graph, test):
111111
for routes in graph['vnet_local_routes']:
112-
for name, rt_list in routes.items():
112+
for name, rt_list in list(routes.items()):
113113
if test['name'] == name.split('_')[0]:
114114
if self.total_routes <= self.max_routes_wo_scaling:
115115
for entry in rt_list:
@@ -124,7 +124,7 @@ def getPeerTest(self, test):
124124
peer_vnets = []
125125
peer_tests = []
126126
for peers in self.peering:
127-
for key, peer in peers.items():
127+
for key, peer in list(peers.items()):
128128
if test['name'] == key:
129129
peer_vnets.append(peer)
130130

@@ -178,14 +178,14 @@ def addLocalTest(self, test, entry):
178178
def calculateTotalRoutes(self, graph):
179179
self.total_routes = 0
180180
for routes in graph['vnet_routes']:
181-
for name, rt_list in routes.items():
181+
for name, rt_list in list(routes.items()):
182182
self.total_routes += len(rt_list)
183183
for peers in graph['vnet_peers']:
184-
for key, peer in peers.items():
184+
for key, peer in list(peers.items()):
185185
if name.split('_')[0] == key:
186186
self.total_routes += len(rt_list)
187187
for l_routes in graph['vnet_local_routes']:
188-
for l_name, l_rt_list in l_routes.items():
188+
for l_name, l_rt_list in list(l_routes.items()):
189189
if name == l_name:
190190
self.total_routes += len(l_rt_list)
191191

@@ -222,7 +222,7 @@ def setUp(self):
222222

223223
self.pc_info = []
224224
self.net_ports = []
225-
for name, val in graph['minigraph_portchannels'].items():
225+
for name, val in list(graph['minigraph_portchannels'].items()):
226226
members = [graph['minigraph_port_indices'][member]
227227
for member in val['members']]
228228
self.net_ports.extend(members)
@@ -239,7 +239,7 @@ def setUp(self):
239239
self.pc_info.append((ip, members))
240240

241241
self.acc_ports = []
242-
for name, data in graph['minigraph_vlans'].items():
242+
for name, data in list(graph['minigraph_vlans'].items()):
243243
ports = [graph['minigraph_port_indices'][member]
244244
for member in data['members'][1:]]
245245
self.acc_ports.extend(ports)
@@ -278,7 +278,7 @@ def setUp(self):
278278

279279
self.tests = []
280280
for routes in graph['vnet_routes']:
281-
for name, rt_list in routes.items():
281+
for name, rt_list in list(routes.items()):
282282
if self.total_routes <= self.max_routes_wo_scaling:
283283
for entry in rt_list:
284284
self.addTest(graph, name, entry)
@@ -345,9 +345,9 @@ def runTest(self):
345345
if not self.vxlan_enabled:
346346
return
347347

348-
print
348+
print()
349349
for test in self.tests:
350-
print(test['name'])
350+
print((test['name']))
351351
self.FromServer(test)
352352
print(" FromServer passed")
353353
self.FromVM(test)
@@ -527,7 +527,7 @@ def FromServer(self, test):
527527
self.packets.append((test['port'], str(pkt).encode("base64")))
528528

529529
finally:
530-
print
530+
print()
531531

532532
def Serv2Serv(self, test):
533533
try:
@@ -589,4 +589,4 @@ def Serv2Serv(self, test):
589589
self.packets.append((test['port'], str(pkt).encode("base64")))
590590

591591
finally:
592-
print
592+
print()

tests/vxlan/test_vnet_vxlan.py

+4-2
Original file line numberDiff line numberDiff line change
@@ -246,15 +246,17 @@ def test_vnet_vxlan(setup, vxlan_status, duthosts, rand_one_dut_hostname, ptfhos
246246
platform_dir="ptftests",
247247
params=ptf_params,
248248
qlen=1000,
249-
log_file=log_file)
249+
log_file=log_file,
250+
is_python3=True)
250251
else:
251252
ptf_runner(ptfhost,
252253
"ptftests",
253254
"vnet_vxlan.VNET",
254255
platform_dir="ptftests",
255256
params=ptf_params,
256257
qlen=1000,
257-
log_file=log_file)
258+
log_file=log_file,
259+
is_python3=True)
258260

259261

260262
def get_expected_flow_counter_packets_number(vnet_json_data):

0 commit comments

Comments
 (0)