YearDisambiguator fixed

Author: wosiu

disambiguation-author/disambiguation-author-logic/src/main/java/pl/edu/icm/coansys/disambiguation/author/features/disambiguators/YearDisambiguator.java

@@ -26,8 +26,12 @@
  * @version 1.0
  * @since 2012-08-07
  */
-public class YearDisambiguator extends Disambiguator{
+public class YearDisambiguator extends Disambiguator {
 
+	public YearDisambiguator() {
+		super();
+	}
+		
 	public YearDisambiguator(double weight, double maxVal) {
 		super(weight, maxVal);
 		if (maxVal == 0) {

disambiguation-author/disambiguation-author-logic/src/test/java/pl/edu/icm/coansys/disambiguation/author/DisambiguationTest.java

@@ -18,6 +18,7 @@
 
 package pl.edu.icm.coansys.disambiguation.author;
 
+import org.testng.Assert;
 import org.testng.annotations.Test;
 
 import java.util.ArrayList;
@@ -36,6 +37,7 @@
 import pl.edu.icm.coansys.disambiguation.author.features.disambiguators.CoAuthorsSnameDisambiguatorFullList;
 import pl.edu.icm.coansys.disambiguation.author.features.disambiguators.CosineSimilarity;
 import pl.edu.icm.coansys.disambiguation.author.features.disambiguators.Disambiguator;
+import pl.edu.icm.coansys.disambiguation.author.features.disambiguators.DisambiguatorFactory;
 import pl.edu.icm.coansys.disambiguation.author.features.disambiguators.Intersection;
 import pl.edu.icm.coansys.disambiguation.author.features.disambiguators.IntersectionPerMaxval;
 import pl.edu.icm.coansys.disambiguation.author.features.disambiguators.IntersectionPerSum;
@@ -183,6 +185,19 @@ public void pig_extractor_DisambiguationExtractorFactory_ALL()
    		}
    	}
 
+   	
+   	@org.testng.annotations.Test(groups = {"fast"})
+   	public void features_disambiguator_factory() {
+   		String featureDescription = "Intersection#whatever#0.0#0";
+		List<FeatureInfo> filist = FeatureInfo.parseFeatureInfoString(featureDescription);
+		FeatureInfo fi = filist.get(0);
+		
+   		DisambiguatorFactory ff = new DisambiguatorFactory();
+   		Disambiguator d = ff.create(fi);
+   		assert(d != null);
+   	}
+   	
+   	
    	@org.testng.annotations.Test(groups = {"fast"})
    	public void features_disambiguator_calculateAffinity() {
    		Disambiguator COAUTH = new CoAuthorsSnameDisambiguatorFullList(1,1);
@@ -290,7 +305,7 @@ public void pig_extractor_EXTRACT_CONTRIBDATA_GIVENDATA_getting_indicators() thr
    		// test "climbing up" through inherited tree of extractor, note that EX_PERSON_COANSYS_ID extends EX_PERSON_ID
    		new EXTRACT_CONTRIBDATA_GIVENDATA("-featureinfo Intersection#EX_PERSON_COANSYS_ID#1.0#1");
    	}
-   	    
+   	
     // Tools:
    	private Tuple contribCreator(Object id, Object sname, 
    			Map<String,DataBag>features){

disambiguation/src/main/java/pl/edu/icm/coansys/disambiguation/features/Disambiguator.java

@@ -83,12 +83,4 @@ public SimpleEntry<Integer, Integer> intersectionAndSum(
 		}
 		return new SimpleEntry<Integer, Integer>(intersection, sum);
 	}
-
-	/**
-	 * 
-	 * @return {@link Disambiguator} id.
-	 */
-	public String getName() {
-		return this.getClass().getSimpleName();
-	}
 }