Make Initiate Function Compatible with Mayan Forwarder #18
+24
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the status of this PR? Is it necessary? Does the deployed Mayan forwarder contract on mainnet require these changes? Is there a release plan? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-order the initiate function of Swap Layer to make it compatible with Mayan Forwarder contract:
MayanForwarder.sol
When a source chain swap is involved, we need to replace the input amount with the output amount of the swap. The forwarder contract expects the input amount to be located at byte 36. To achieve this, we have reordered the input parameters of the initiate function and added an amountIn parameter that will replace the current amount in the parameters.