Skip to content
This repository has been archived by the owner on Jun 2, 2024. It is now read-only.

Prioritize Language Track (Default: English) #8

Open
zenjabba opened this issue Feb 25, 2019 · 1 comment
Open

Prioritize Language Track (Default: English) #8

zenjabba opened this issue Feb 25, 2019 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@zenjabba
Copy link

If English isn't the first audio language track, move that full english audio track to position 1.

@wolveix wolveix added the enhancement New feature or request label Mar 2, 2019
@wolveix
Copy link
Owner

wolveix commented Mar 8, 2019

Hey! Sorry for taking so long to reply to this, I've been incredibly busy with work. This is a great idea, and I had thought of it a long time ago. The issue with implementing this is that it wouldn't really be doable with how Plexus currently handles stream mapping.

I imagine this would work by using FFprobe to list the available audio streams with their respective language tags (if present) like this, and then remapping their source ID to 1 if they're English. The reason that this is a problem is because we map all streams by using FFmpeg's -map 0 flag. By implementing this desired functionality, we would need to increment all of the other stream IDs to allow for the insertion.

Due to being busy at the moment, I'll have to leave this unimplemented. But if someone else would happen to be nice enough to implement this and submit a pull request, I would be more than happy to review and merge it :)

Thanks for the request!

@wolveix wolveix added the help wanted Extra attention is needed label Mar 8, 2019
@wolveix wolveix added this to the v1.0 milestone Oct 28, 2019
@wolveix wolveix changed the title Feature Request Prioritize Language Track (Default: English) Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants