Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

navigation API: resolve the finished promise #11064

Open
atscott opened this issue Feb 21, 2025 · 0 comments
Open

navigation API: resolve the finished promise #11064

atscott opened this issue Feb 21, 2025 · 0 comments

Comments

@atscott
Copy link

atscott commented Feb 21, 2025

What is the issue with the HTML Standard?

In the navigation API's resolve the finished promise steps, it includes the following:

Resolve apiMethodTracker's committed promise with its committed-to entry.

Usually, notify about the committed-to entry has previously been called on apiMethodTracker, and so this will do nothing. However, in some cases resolve the finished promise is called directly, in which case this step is necessary.

I don't believe this is accurate and think the step and note should be removed. From what I can tell, resolve should never be called without the commit steps having already been run. If not, the committed-to entry would still be null unless there is some place that sets it without doing the other steps in notifying about the committed-to and I don't think that's the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant