generated from wharfkit/wallet-plugin-template
-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modal/optional inline login? #11
Comments
I'm not entirely sure, might take some coordination with the cloud wallet team. If I recall correctly, the cloud wallet might not work in an iframe - which is probably the only other approach we could take to prevent it from being a popup window. All the processes happen on their domain, so it's got to be presented somehow. |
That sounds plausible to me thanks for the reply. I did some testing with
electron and seems if I build it with a deployed site I.e just loading a
url it works perfect and if you do static page way it will not work due to
some error I assume is no referrer url or unknown. It did used to work in
the old one though as I was using the wcw successfully in unreal engine.
Now however it’s no longer going to work even when managing pop up
correctly internally. Can’t debug inside ue (least I can’t figure out how)
which is why I thought opening as I frame maybe an option. Thanks again for
your help
Let’s see what can be done.
…On Sun, 24 Mar 2024 at 09:02, Aaron Cox ***@***.***> wrote:
I'm not entirely sure, might take some coordination with the cloud wallet
team.
If I recall correctly, the cloud wallet might not work in an iframe -
which is probably the only other approach we could take to prevent it from
being a popup window. All the processes happen on their domain, so it's got
to be presented somehow.
—
Reply to this email directly, view it on GitHub
<#11 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB2BKF3KKZVFYOYP2WEEJ4DYZ2JEHAVCNFSM6AAAAABFFC6TH6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJWG42DCNJSGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
any chance of having it not open a new window to log a user in but a modal similar to how wombat is opening the selection of added plugins... or does one exist?
The text was updated successfully, but these errors were encountered: