Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from netdata:master #362

Merged
merged 7 commits into from
Feb 13, 2025
Merged

Conversation

pull[bot]
Copy link

@pull pull bot commented Feb 13, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

Summary by Sourcery

Update the order of stack trace and request fields in logs and adjust message formatting.

Enhancements:

  • Standardize the documentation for Graphite integration across different providers (Blueflood, KairosDB, and Graphite itself).
  • Remove redundant prerequisites section from the Graphite integration documentation for Blueflood, KairosDB, and Graphite.

ilyam8 and others added 7 commits February 13, 2025 10:23
Co-authored-by: ilyam8 <22274335+ilyam8@users.noreply.github.com>
* docs(exporting): clarify graphite exporters

* rm prerequisites
Co-authored-by: ilyam8 <22274335+ilyam8@users.noreply.github.com>
Revert "fix windows logs (#19632)"

This reverts commit d8c3dc0.
@pull pull bot added the ⤵️ pull label Feb 13, 2025
@pull pull bot merged commit bca67f2 into webfutureiorepo:master Feb 13, 2025
Copy link

sourcery-ai bot commented Feb 13, 2025

Reviewer's Guide by Sourcery

This pull request reorders log field definitions for compatibility with the Windows Event Log, updates exporter descriptions to remove the Graphite dependency, and removes the InfluxDB exporter.

Updated class diagram for log fields

classDiagram
    class log_field {
        +journal: string
        +eventlog: string
        +logfmt: string
    }

    class NDF_ENUM {
        NDF_ALERT_SUMMARY = 60
        NDF_ALERT_INFO = 61
        NDF_ALERT_NOTIFICATION_REALTIME_USEC = 62
        NDF_REQUEST = 63
        NDF_MESSAGE = 64
        NDF_STACK_TRACE = 65
    }

    note for NDF_ENUM "Reordered NDF_REQUEST, NDF_MESSAGE, and NDF_STACK_TRACE"
Loading

File-Level Changes

Change Details Files
Reordered the definitions of NDF_STACK_TRACE, NDF_REQUEST, and NDF_MESSAGE in the nd_log subsystem to align with the Windows Event Log (WEVT) manifest requirements.
  • Swapped the positions of NDF_STACK_TRACE and NDF_MESSAGE in the nd_log enum.
  • Updated the WEVT manifest generation code to reflect the new order of the fields.
src/libnetdata/log/wevt_netdata_mc_generate.c
src/libnetdata/log/nd_log-internals.c
src/libnetdata/log/nd_log-common.h
Updated the descriptions of the Blueflood and KairosDB exporters to remove the Graphite dependency.
  • Modified the overview.exporter_description field in exporting/graphite/metadata.yaml for Blueflood and KairosDB to remove the reference to Graphite.
  • Updated the Blueflood and KairosDB integration documentation to remove the Graphite dependency.
  • Removed the 'You have already installed Netdata and Graphite' prerequisite from the Blueflood, Graphite and KairosDB integration documentation.
src/exporting/graphite/metadata.yaml
src/exporting/graphite/integrations/blueflood.md
src/exporting/graphite/integrations/kairosdb.md
src/exporting/graphite/integrations/graphite.md
Removed the InfluxDB exporter.
  • Removed the InfluxDB exporter configuration from exporting/graphite/metadata.yaml.
  • Removed the InfluxDB integration documentation.
src/exporting/graphite/metadata.yaml
src/exporting/graphite/integrations/influxdb.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants