Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from netdata:master #352

Merged
merged 1 commit into from
Feb 8, 2025
Merged

Conversation

pull[bot]
Copy link

@pull pull bot commented Feb 8, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

Summary by Sourcery

Chores:

  • Remove stale contexts.

@pull pull bot added the ⤵️ pull label Feb 8, 2025
@pull pull bot merged commit 672dba1 into webfutureiorepo:master Feb 8, 2025
Copy link

sourcery-ai bot commented Feb 8, 2025

Reviewer's Guide by Sourcery

The pull request introduces a new helper function to dequeue a context from the hub queue and integrates it into the context deletion logic. This is implemented by adding a new function prototype and its invocation in an existing function within the worker context file.

Sequence diagram for context deletion in worker context

sequenceDiagram
    participant Delete as rrdcontext_delete_after_loading
    participant Hub as rrdcontext_dequeue_from_hub_queue
    participant Post as rrdcontext_dequeue_from_post_processing
    participant Dict as dictionary_del

    Delete->>Hub: Call rrdcontext_dequeue_from_hub_queue(rc)
    Hub-->>Delete: Return
    Delete->>Post: Call rrdcontext_dequeue_from_post_processing(rc)
    Post-->>Delete: Return
    Delete->>Dict: Call dictionary_del(host->rrdctx.contexts, string2str(rc->id))
    Dict-->>Delete: Return
Loading

File-Level Changes

Change Details Files
Introduced and integrated the rrdcontext_dequeue_from_hub_queue function.
  • Added a new function declaration for rrdcontext_dequeue_from_hub_queue in the worker context file.
  • Inserted a call to rrdcontext_dequeue_from_hub_queue within the rrdcontext_delete_after_loading function to ensure proper dequeue processing during deletion.
src/database/contexts/worker.c

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant