Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from netdata:master #344

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Conversation

pull[bot]
Copy link

@pull pull bot commented Feb 6, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

Summary by Sourcery

Enhancements:

  • Simplify configuration parsing logic by removing unnecessary code and improving variable initialization.

format_main: Apply format to ebpf.c file
@pull pull bot added the ⤵️ pull label Feb 6, 2025
@pull pull bot merged commit 95ffceb into webfutureiorepo:master Feb 6, 2025
Copy link

sourcery-ai bot commented Feb 6, 2025

Reviewer's Guide by Sourcery

This pull request focuses on improving the readability and maintainability of the eBPF collector code. It achieves this by reformatting boolean checks, removing redundant variable assignments, and ensuring consistent code style throughout the file.

Flow diagram for eBPF collector configuration process

graph TD
    A[Start Configuration] --> B[Parse Network Viewer Section]
    B --> C{Check Hostname Resolution}
    C -->|Enabled| D[Parse Hostnames]
    C -->|Disabled| E[Skip Hostname Parsing]
    B --> F[Parse Service Resolution]
    B --> G[Parse Ports]
    B --> H[Parse IPs]
    A --> I[Update Global Settings]
    I --> J[Update Interval]
    I --> K[Update Table Size]
    I --> L[Update Lifetime]
    I --> M[Update Map Per Core]
    A --> N[Configure eBPF Programs]
    N --> O{Enable/Disable Programs}
    O --> P[Process Monitor]
    O --> Q[Network Viewer]
    O --> R[Other Modules]
    style A fill:#f9f,stroke:#333,stroke-width:2px
    style N fill:#bbf,stroke:#333,stroke-width:2px
    style O fill:#dfd,stroke:#333,stroke-width:2px
Loading

File-Level Changes

Change Details Files
Improved readability by reformatting boolean checks.
  • Reformatted boolean checks for enabling/disabling features based on configuration values.
  • Used direct boolean evaluation instead of comparing with CONFIG_BOOLEAN_NO and CONFIG_BOOLEAN_YES.
src/collectors/ebpf.plugin/ebpf.c
Removed redundant variable assignments.
  • Removed unnecessary assignment of the enabled variable when its value is immediately used.
  • Simplified the logic for determining whether apps and cgroups are disabled.
src/collectors/ebpf.plugin/ebpf.c
Ensured consistent code style.
  • Reformatted lines to adhere to consistent indentation and spacing.
  • Aligned variable assignments for better readability.
src/collectors/ebpf.plugin/ebpf.c

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant