Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from netdata:master #333

Merged
merged 7 commits into from
Jan 31, 2025
Merged

Conversation

pull[bot]
Copy link

@pull pull bot commented Jan 31, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

Summary by Sourcery

New Features:

  • Added charts for .NET CLR Remoting, Security, and LocksAndThreads performance counters.

@pull pull bot added the ⤵️ pull label Jan 31, 2025
@pull pull bot merged commit 0565c01 into webfutureiorepo:master Jan 31, 2025
Copy link

sourcery-ai bot commented Jan 31, 2025

Reviewer's Guide by Sourcery

This pull request introduces new metrics for the .NET CLR, specifically focusing on remoting, security, and locks/threads. It also refactors the eBPF code to use a common header for shared data structures and adds a new SMSEagle notification option.

Class diagram for new .NET CLR metrics

classDiagram
    class net_framework_instances {
        +RRDSET* st_clrremoting_channels
        +RRDDIM* rd_clrremoting_channels
        +RRDSET* st_clrremoting_context_bound_classes_loaded
        +RRDDIM* rd_clrremoting_context_bound_classes_loaded
        +RRDSET* st_clrsecurity_link_time_checks
        +RRDDIM* rd_clrsecurity_link_time_checks
        +RRDSET* st_clrlocksandthreads_queue_length
        +RRDDIM* rd_locksandthreads_queue_length
        +COUNTER_DATA NETFrameworkCLRRemotingChannels
        +COUNTER_DATA NETFrameworkCLRSecurityLinkTimeChecks
        +COUNTER_DATA NETFrameworkCLRLocksAndThreadsQueueLength
    }

    class netdata_netframework_metrics {
        <<enumeration>>
        NETDATA_NETFRAMEWORK_INTEROP
        NETDATA_NETFRAMEWORK_JIT
        NETDATA_NETFRAMEWORK_LOADING
        NETDATA_NETFRAMEWORK_REMOTING
        NETDATA_NETFRAMEWORK_SECURITY
        NETDATA_NETFRAMEWORK_LOCKS_THREADS
    }
Loading

Class diagram for eBPF shared data structures

classDiagram
    class ebpf_pids_index {
        <<enumeration>>
        NETDATA_EBPF_PIDS_PROCESS_IDX
        NETDATA_EBPF_PIDS_SOCKET_IDX
        NETDATA_EBPF_PIDS_CACHESTAT_IDX
        NETDATA_EBPF_PIDS_DCSTAT_IDX
        NETDATA_EBPF_PIDS_SWAP_IDX
        NETDATA_EBPF_PIDS_VFS_IDX
        NETDATA_EBPF_PIDS_FD_IDX
        NETDATA_EBPF_PIDS_SHM_IDX
        NETDATA_EBPF_PIDS_PROC_FILE
        NETDATA_EBPF_PIDS_END_IDX
    }

    class netdata_ebpf_pid_stats {
        +ebpf_process_stat_t process
        +netdata_socket_t socket
        +netdata_cachestat_pid_t cachestat
        +netdata_dcstat_pid_t directory_cache
        +netdata_ebpf_swap_t swap
        +netdata_ebpf_vfs_t vfs
        +netdata_fd_stat_t fd
        +netdata_ebpf_shm_t shm
    }
Loading

File-Level Changes

Change Details Files
Added new metrics for .NET CLR Remoting.
  • Added new enum values for remoting metrics.
  • Added new RRDSET and RRDDIM structures for remoting metrics.
  • Added new COUNTER_DATA structures for remoting metrics.
  • Initialized keys for remoting metrics.
  • Added a new function to collect remoting metrics.
src/collectors/windows.plugin/perflib-netframework.c
Added new metrics for .NET CLR Security.
  • Added new enum values for security metrics.
  • Added new RRDSET and RRDDIM structures for security metrics.
  • Added new COUNTER_DATA structures for security metrics.
  • Initialized keys for security metrics.
  • Added a new function to collect security metrics.
src/collectors/windows.plugin/perflib-netframework.c
Added new metrics for .NET CLR Locks and Threads.
  • Added new enum values for locks and threads metrics.
  • Added new RRDSET and RRDDIM structures for locks and threads metrics.
  • Added new COUNTER_DATA structures for locks and threads metrics.
  • Initialized keys for locks and threads metrics.
  • Added a new function to collect locks and threads metrics.
src/collectors/windows.plugin/perflib-netframework.c
Refactored eBPF code to use a common header for shared data structures.
  • Created a new header file collectors-ipc/collectors-ipc.h to define shared data structures.
  • Removed redundant structure definitions from individual eBPF collector headers.
  • Updated eBPF collector source files to use the shared data structures from the new header.
  • Updated the eBPF pids index enum to use a common definition.
  • Updated the eBPF thread functions to use the new pids index enum.
src/collectors/ebpf.plugin/ebpf_apps.h
src/collectors/ebpf.plugin/ebpf_vfs.h
src/collectors/ebpf.plugin/ebpf_socket.h
src/collectors/ebpf.plugin/ebpf_cachestat.h
src/collectors/ebpf.plugin/ebpf_shm.h
src/collectors/ebpf.plugin/ebpf_dcstat.h
src/collectors/ebpf.plugin/ebpf_fd.h
src/collectors/ebpf.plugin/ebpf_swap.h
src/collectors/ebpf.plugin/ebpf_apps.c
src/collectors/ebpf.plugin/ebpf_cachestat.c
src/collectors/ebpf.plugin/ebpf_dcstat.c
src/collectors/ebpf.plugin/ebpf_fd.c
src/collectors/ebpf.plugin/ebpf_shm.c
src/collectors/ebpf.plugin/ebpf_swap.c
src/collectors/ebpf.plugin/ebpf_vfs.c
src/collectors/ebpf.plugin/ebpf_socket.c
src/collectors/ebpf.plugin/ebpf_process.c
src/collectors/ebpf.plugin/ebpf.c
Added a new SMSEagle notification option.
  • Added new configuration options for SMSEagle.
  • Added a new section for SMSEagle in the configuration file.
  • Added a new README.md file for SMSEagle.
  • Added a new metadata.yaml file for SMSEagle.
src/health/notifications/health_alarm_notify.conf
src/health/notifications/smseagle/README.md
src/health/notifications/smseagle/metadata.yaml
Added cmake cache to build info.
  • Added logic to archive the cmake cache.
  • Added logic to print the cmake cache.
  • Added a new command line option to print the cmake cache.
CMakeLists.txt
src/daemon/buildinfo.c
src/daemon/buildinfo.h
Updated various files to use the new rrd.h header.
  • Replaced the daemon/common.h header with database/rrd.h.
src/collectors/windows.plugin/windows_plugin.h
src/database/sqlite/sqlite_db_migration.h
src/web/server/web_server.h
src/ml/ml_public.h
src/aclk/aclk_capas.h
src/aclk/aclk_query_queue.h
src/aclk/aclk.h
src/aclk/aclk_alarm_api.h
src/aclk/aclk_otp.h
src/aclk/aclk_proxy.c
src/aclk/aclk_util.c
src/collectors/all.h
src/collectors/cgroups.plugin/sys_fs_cgroup.h
src/collectors/timex.plugin/plugin_timex.c
src/database/engine/dbengine-stresstest.c
src/database/engine/dbengine-unittest.c
src/database/rrdhost-system-info.c
src/database/sqlite/sqlite_context.h
src/database/sqlite/sqlite_functions.h
src/database/sqlite/sqlite_health.h
src/exporting/exporting_engine.h
src/health/health.h
src/plugins.d/pluginsd_parser.h
src/registry/registry.c
src/registry/registry.h
src/registry/registry_db.c
src/registry/registry_init.c
src/registry/registry_internals.c
src/registry/registry_log.c
src/registry/registry_machine.c
src/registry/registry_person.c
src/streaming/stream-conf.c
src/streaming/stream-replication-sender.h
src/web/api/functions/function-bearer_get_token.h
src/web/api/functions/function-progress.h
src/web/api/functions/function-streaming.h
src/web/api/functions/functions.h
src/web/api/queries/weights.c
src/web/api/web_api.h
src/web/server/h2o/http_server.c
src/web/server/h2o/rrdpush.c
src/web/server/web_client.h
src/database/engine/rrdengine.h
src/collectors/freebsd.plugin/plugin_freebsd.h
src/collectors/idlejitter.plugin/plugin_idlejitter.c
src/collectors/macos.plugin/plugin_macos.h
src/collectors/proc.plugin/plugin_proc.h
src/collectors/proc.plugin/zfs_common.h
src/collectors/profile.plugin/plugin_profile.cc
src/collectors/slabinfo.plugin/slabinfo.c
src/collectors/statsd.plugin/statsd.c
src/collectors/tc.plugin/plugin_tc.c
src/daemon/main.c
src/ml/ml_public.cc
src/database/sqlite/sqlite_metadata.c
src/collectors/ebpf.plugin/ebpf_socket.c

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants