Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from netdata:master #313

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Conversation

pull[bot]
Copy link

@pull pull bot commented Jan 21, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

Summary by Sourcery

Disable libunwind on all architectures and enable eBPF on amd64.

Build:

  • Removed the CMake option to enable libunwind for all architectures.
  • Enabled the eBPF plugin specifically for the amd64 architecture.

* Revert "Enable libunwind in Docker images. (#19409)"

This reverts commit 361f6d2.

* Revert "Enable libunwind in DEB native packages. (#19417)"

This reverts commit 3d09660.
@pull pull bot added the ⤵️ pull label Jan 21, 2025
@pull pull bot merged commit 0e08196 into webfutureiorepo:master Jan 21, 2025
Copy link

sourcery-ai bot commented Jan 21, 2025

Reviewer's Guide by Sourcery

This pull request disables the libunwind dependency for all architectures and disables the eBPF plugin for arm64.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Disabled libunwind dependency.
  • Removed the ENABLE_LIBUNWIND cmake option for all architectures in packaging/build-package.sh.
  • Removed the ENABLE_LIBUNWIND cmake option in packaging/docker/Dockerfile.
packaging/build-package.sh
packaging/docker/Dockerfile
Disabled eBPF plugin for arm64.
  • Set ENABLE_PLUGIN_EBPF to Off for the arm64 architecture in packaging/build-package.sh.
packaging/build-package.sh

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant