Protect metric release in dimension delete callback (netdata#17020)

Protect metric release
webfutureiorepo · Feb 16, 2024 · dea9d1f · dea9d1f
1 parent 43eab7b
commit dea9d1f
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/src/database/rrddim.c b/src/database/rrddim.c
@@ -206,11 +206,13 @@ static void rrddim_delete_callback(const DICTIONARY_ITEM *item __maybe_unused, v
     }
 
     for(size_t tier = 0; tier < storage_tiers ;tier++) {
-        if(!rd->tiers[tier].smh) continue;
-
-        STORAGE_ENGINE* eng = host->db[tier].eng;
-        eng->api.metric_release(rd->tiers[tier].smh);
-        rd->tiers[tier].smh = NULL;
+        spinlock_lock(&rd->tiers[tier].spinlock);
+        if(rd->tiers[tier].smh) {
+            STORAGE_ENGINE *eng = host->db[tier].eng;
+            eng->api.metric_release(rd->tiers[tier].smh);
+            rd->tiers[tier].smh = NULL;
+        }
+        spinlock_unlock(&rd->tiers[tier].spinlock);
     }
 
     if(rd->db.data) {