prevent memory corruption in dbengine (netdata#19365)

prevent memory corruption
webfutureiorepo · Jan 10, 2025 · a553390 · a553390
1 parent d447f55
commit a553390
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/database/engine/rrdengineapi.c b/src/database/engine/rrdengineapi.c
@@ -911,8 +911,10 @@ void rrdeng_load_metric_finalize(struct storage_engine_query_handle *seqh)
         pgdc_reset(&handle->pgdc, NULL, UINT32_MAX);
     }
 
-    if(!pdc_release_and_destroy_if_unreferenced(handle->pdc, false, false))
+    if(handle->pdc) {
         __atomic_store_n(&handle->pdc->workers_should_stop, true, __ATOMIC_RELAXED);
+        pdc_release_and_destroy_if_unreferenced(handle->pdc, false, false);
+    }
 
     unregister_query_handle(handle);
     rrdeng_query_handle_release(handle);