From 39352b7cedabc343e0d2ab478e30089e47dd3038 Mon Sep 17 00:00:00 2001 From: Marcin Date: Wed, 12 Feb 2025 11:32:48 +0000 Subject: [PATCH] fi: disable turn tcp (#4096) --- .../@webex/plugin-meetings/src/media/index.ts | 22 +++++++++---------- .../test/unit/spec/media/index.ts | 20 ++++++++--------- .../test/unit/spec/meeting/index.js | 10 ++++----- 3 files changed, 26 insertions(+), 26 deletions(-) diff --git a/packages/@webex/plugin-meetings/src/media/index.ts b/packages/@webex/plugin-meetings/src/media/index.ts index 9f5521fc75e..878185a6516 100644 --- a/packages/@webex/plugin-meetings/src/media/index.ts +++ b/packages/@webex/plugin-meetings/src/media/index.ts @@ -163,17 +163,17 @@ Media.createMediaConnection = ( // we might not have any TURN server if TURN discovery failed or wasn't done or // we might get an empty TURN url if we land on a video mesh node if (turnServerInfo?.url) { - if (!isBrowser('firefox')) { - let bareTurnServer = turnServerInfo.url; - bareTurnServer = bareTurnServer.replace('turns:', 'turn:'); - bareTurnServer = bareTurnServer.replace('443', '5004'); - - iceServers.push({ - urls: bareTurnServer, - username: turnServerInfo.username || '', - credential: turnServerInfo.password || '', - }); - } + // if (!isBrowser('firefox')) { + // let bareTurnServer = turnServerInfo.url; + // bareTurnServer = bareTurnServer.replace('turns:', 'turn:'); + // bareTurnServer = bareTurnServer.replace('443', '5004'); + + // iceServers.push({ + // urls: bareTurnServer, + // username: turnServerInfo.username || '', + // credential: turnServerInfo.password || '', + // }); + // } // TURN-TLS server iceServers.push({ diff --git a/packages/@webex/plugin-meetings/test/unit/spec/media/index.ts b/packages/@webex/plugin-meetings/test/unit/spec/media/index.ts index 366d3ccb4b1..5e7cb5cee32 100644 --- a/packages/@webex/plugin-meetings/test/unit/spec/media/index.ts +++ b/packages/@webex/plugin-meetings/test/unit/spec/media/index.ts @@ -90,11 +90,11 @@ describe('createMediaConnection', () => { roapMediaConnectionConstructorStub, { iceServers: [ - { - urls: 'turn:turn-server-url:5004?transport=tcp', - username: 'turn username', - credential: 'turn password', - }, + // { + // urls: 'turn:turn-server-url:5004?transport=tcp', + // username: 'turn username', + // credential: 'turn password', + // }, { urls: 'turns:turn-server-url:443?transport=tcp', username: 'turn username', @@ -170,11 +170,11 @@ describe('createMediaConnection', () => { multistreamRoapMediaConnectionConstructorStub, { iceServers: [ - { - urls: 'turn:turn-server-url:5004?transport=tcp', - username: 'turn username', - credential: 'turn password', - }, + // { + // urls: 'turn:turn-server-url:5004?transport=tcp', + // username: 'turn username', + // credential: 'turn password', + // }, { urls: 'turns:turn-server-url:443?transport=tcp', username: 'turn username', diff --git a/packages/@webex/plugin-meetings/test/unit/spec/meeting/index.js b/packages/@webex/plugin-meetings/test/unit/spec/meeting/index.js index 14ea0c1526b..13abdd70e59 100644 --- a/packages/@webex/plugin-meetings/test/unit/spec/meeting/index.js +++ b/packages/@webex/plugin-meetings/test/unit/spec/meeting/index.js @@ -3772,11 +3772,11 @@ describe('plugin-meetings', () => { expectedDebugId = `MC-${meeting.id.substring(0, 4)}`; expectedMediaConnectionConfig = { iceServers: [ - { - urls: 'turn:turn-server-url:5004?transport=tcp', - username: 'turn user', - credential: 'turn password', - }, + // { + // urls: 'turn:turn-server-url:5004?transport=tcp', + // username: 'turn user', + // credential: 'turn password', + // }, { urls: 'turns:turn-server-url:443?transport=tcp', username: 'turn user',