Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loot table related recipe categories are not populated when connecting to a dedicated server #533

Open
mred231 opened this issue Mar 6, 2025 · 0 comments

Comments

@mred231
Copy link

mred231 commented Mar 6, 2025

I was also running into a similar issue as #524.

tl;dr:
From poking around in the code, I believe it's due to LootTableFetcher not being set with a ReloadableServerRegistry here: https://github.com/way2muchnoise/JustEnoughResources/blob/master/Common/src/main/java/jeresources/util/LootTableHelper.java#L162-L179

  1. Loot table based recipe categories call lootTableFetcher.getLootTable during initiation. e.g. https://github.com/way2muchnoise/JustEnoughResources/blob/master/Common/src/main/java/jeresources/compatibility/minecraft/MinecraftCompat.java#L43
  2. When JER is run in the client only, the reloadable registry is unavailable and gets skipped here: https://github.com/way2muchnoise/JustEnoughResources/blob/master/Common/src/main/java/jeresources/util/LootTableHelper.java#L162-L179
  3. When reloadableServerRegistries in LootTableFetcher is null, an empty loot table is returned: https://github.com/way2muchnoise/JustEnoughResources/blob/master/Common/src/main/java/jeresources/util/LootTableFetcher.java#L19-L21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant