Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow footer compatible with sidebar #1037

Open
4 tasks done
Otto-J opened this issue Jul 22, 2022 · 5 comments · May be fixed by #4532
Open
4 tasks done

Allow footer compatible with sidebar #1037

Otto-J opened this issue Jul 22, 2022 · 5 comments · May be fixed by #4532
Labels
theme Related to the theme

Comments

@Otto-J
Copy link

Otto-J commented Jul 22, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.

Now footer and sidebar cannot be used at the same time. We hope they can appear at the same time.

Describe the solution you'd like

  • footer and sidebar can used at the same time

Describe alternatives you've considered

If allowed, maybe I can provide a PR？

Additional context

No response

Validations
@Otto-J
Copy link
Author

Otto-J commented Jul 22, 2022 •
edited
Loading

footer support v-html now #1034 (comment)

@Otto-J Otto-J closed this as completed Jul 22, 2022
@Otto-J Otto-J changed the title Allow footer to display rich text, compatible with sidebar Allow footer compatible with sidebar Jul 22, 2022
@Otto-J Otto-J reopened this Jul 22, 2022
@brc-dd
Copy link
Member

brc-dd commented Jul 22, 2022

It doesn't look nice with sidebar, that's why its not there. If you want to create a PR, then make it optional to enable footer (using frontmatter or some theme config) on doc pages.

@xsjcTony
Copy link
Contributor

Yeah honestly it would be good, especially if we need to display some must-have copyright info or something else.

@brc-dd brc-dd added enhancement theme Related to the theme labels Aug 3, 2023
@github-actions github-actions bot added the stale label Sep 16, 2023
@rocex
Copy link

rocex commented Jun 21, 2024

Here's how I solved it
in .vitepress\theme\style.css add this

footer.VPFooter {
    display: block !important;
}

@github-actions github-actions bot removed the stale label Jun 23, 2024
@github-actions github-actions bot added the stale label Sep 1, 2024
@github-actions github-actions bot removed the stale label Jan 20, 2025
@yuyinws yuyinws linked a pull request Jan 31, 2025 that will close this issue
Open
@ronny1020
Copy link

Instead of enforcing a specific design choice, wouldn't it be better to let users decide whether to use the footer, the sidebar, or both? If someone doesn't like the look, they could simply remove or hide the footer/sidebar in their own configuration. Is there a specific technical reason why this flexibility isn't allowed?

@chenrui333 chenrui333 mentioned this issue Feb 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
theme Related to the theme
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(theme): allow footer and sidebar to be displayed at the same time yuyinws/vitepress
5 participants
@rocex @Otto-J @brc-dd @xsjcTony @ronny1020