Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Suspense): also update Suspense vnode's el during branch self-update #12922

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(Suspense): also update Suspense vnode's el during branch self-update #12922

wants to merge 3 commits into from

Conversation

edison1105
Copy link
Member

close #12920

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 20, 2025 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 101 kB (+68 B) 38.1 kB (+16 B) 34.4 kB (+61 B)
vue.global.prod.js 158 kB (+68 B) 58 kB (+15 B) 51.7 kB (+18 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.6 kB (+68 B) 18.3 kB (+14 B) 16.7 kB (+13 B)
createApp 54.6 kB (+68 B) 21.3 kB (+14 B) 19.5 kB (+14 B)
createSSRApp 58.8 kB (+68 B) 23.1 kB (+23 B) 21 kB (+44 B)
defineCustomElement 59.5 kB (+68 B) 22.9 kB (+14 B) 20.8 kB (+14 B)
overall 68.7 kB (+68 B) 26.5 kB (+12 B) 24 kB (-32 B)

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Feb 20, 2025 •
edited
Loading

Open in Stackblitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@12922

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@12922

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@12922

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@12922

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@12922

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@12922

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@12922

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@12922

@vue/shared

npm i https://pkg.pr.new/@vue/shared@12922

vue

npm i https://pkg.pr.new/vue@12922

@vue/compat

npm i https://pkg.pr.new/@vue/compat@12922

commit: 2c12b58

@edison1105
Copy link
Member Author

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Feb 20, 2025

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools ✅ success ✅ success
nuxt ✅ success ✅ success
pinia ✅ success ✅ success
primevue ✅ success ✅ success
quasar ✅ success ✅ success
radix-vue ✅ success ✅ success
router ✅ success ✅ success
test-utils ✅ success ✅ success
vant ✅ success ✅ success
vite-plugin-vue ✅ success ✅ success
vitepress ✅ success ✅ success
vue-i18n ✅ success ✅ success
vue-macros ❌ failure ✅ success
vuetify ✅ success ✅ success
vueuse ✅ success ✅ success
vue-simple-compiler ✅ success ✅ success

@edison1105 edison1105 force-pushed the edison/fix/suspenseChildrenSelfUpdate branch 2 times, most recently from 61ebab0 to 1b01b0f Compare February 21, 2025 01:15
@edison1105 edison1105 added ready to merge The PR is ready to be merged. scope: suspense 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. labels Feb 21, 2025
@edison1105 edison1105 changed the title fix(runtime-core): synchronously update Suspense vnode's el during component self-update fix(Suspense): synchronously update Suspense vnode's el during children self-update Feb 21, 2025
@edison1105 edison1105 force-pushed the edison/fix/suspenseChildrenSelfUpdate branch from 1b01b0f to c52332a Compare February 21, 2025 06:33
@edison1105 edison1105 marked this pull request as draft February 21, 2025 08:54
@edison1105 edison1105 removed the ready to merge The PR is ready to be merged. label Feb 21, 2025
@edison1105 edison1105 changed the title fix(Suspense): synchronously update Suspense vnode's el during children self-update fix(Suspense): also update Suspense vnode's el during branch self-update Feb 21, 2025
@edison1105 edison1105 marked this pull request as ready for review February 21, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. scope: suspense
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suspense unmounts with an error if it renders a component with a root node implementing a client-only behavior
2 participants
@edison1105 @vue-bot