Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(reactivity): readonly ref able to trigger by triggerRef #12804

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(reactivity): readonly ref able to trigger by triggerRef #12804

wants to merge 4 commits into from
+21 −0

Conversation

serkodev
Copy link
Contributor

@serkodev serkodev commented Feb 2, 2025

Fix #12803

This PR adds dep to isNonTrackableKeys so that the readonly proxy does not convert dep to a readonly value, allowing it to be triggered by triggerRef.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 2, 2025 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB (+17 B) 38 kB (+7 B) 34.2 kB (-15 B)
vue.global.prod.js 158 kB (+17 B) 57.8 kB (+5 B) 51.5 kB (+63 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.4 kB (+17 B) 18.2 kB (+6 B) 16.6 kB (+9 B)
createApp 54.3 kB (+17 B) 21.2 kB (+6 B) 19.3 kB (+5 B)
createSSRApp 58.5 kB (+17 B) 22.9 kB (+6 B) 20.9 kB (+12 B)
defineCustomElement 59.2 kB (+17 B) 22.8 kB (+4 B) 20.7 kB (+8 B)
overall 68.4 kB (+17 B) 26.3 kB (+4 B) 23.9 kB (-40 B)

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Feb 2, 2025 •
edited
Loading

Open in Stackblitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@12804

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@12804

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@12804

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@12804

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@12804

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@12804

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@12804

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@12804

@vue/shared

npm i https://pkg.pr.new/@vue/shared@12804

vue

npm i https://pkg.pr.new/vue@12804

@vue/compat

npm i https://pkg.pr.new/@vue/compat@12804

commit: 3be87c1

@edison1105 edison1105 added 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. wait changes labels Feb 3, 2025
@edison1105
Copy link
Member

/ecosystem-ci run

@edison1105 edison1105 added ready to merge The PR is ready to be merged. and removed wait changes labels Feb 3, 2025
@edison1105
Copy link
Member

LGTM

@edison1105 edison1105 changed the title fix: readonly ref able to trigger by triggerRef fix(reactivity): readonly ref able to trigger by triggerRef Feb 3, 2025
@vue-bot
Copy link
Contributor

vue-bot commented Feb 3, 2025

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools ✅ success ❌ failure
nuxt ✅ success ❌ failure
pinia ✅ success ❌ failure
primevue ✅ success ❌ failure
quasar ✅ success ❌ failure
radix-vue ✅ success ❌ failure
router ✅ success ❌ failure
test-utils ✅ success ❌ failure
vant ✅ success ❌ failure
vite-plugin-vue ✅ success ❌ failure
vitepress ✅ success ❌ failure
vue-i18n ✅ success ❌ failure
vue-macros ✅ success ❌ failure
vuetify ✅ success ❌ failure
vueuse ✅ success ❌ failure
vue-simple-compiler ✅ success ❌ failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edison1105 edison1105 edison1105 approved these changes

@skirtles-code skirtles-code Awaiting requested review from skirtles-code

Assignees
No one assigned
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready to merge The PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Readonly Ref cannot be triggered by triggerRef
4 participants
@serkodev @edison1105 @vue-bot @skirtles-code