Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The login button should show SpreadsheetAccess when on a spreadsheet election #131

Open
elboletaire opened this issue Jan 22, 2024 · 0 comments
Labels
chakra-components Things related to the chakra-components package enhancement New feature or request

Comments

@elboletaire
Copy link
Member

I'm not sure if it's really a good idea to change the default login button behavior... it'll be better to create a new login button that unifies this logic, because I can see cases where developers would like to maintain the normal login button.

In implementations like ui-scaffold, where there's always the login button visible, in spreadsheet census strategy elections can lead to confusion, since they use their custom login flow.

Let's create a new login button that would show the spreadsheet login modal on these cases. This may require creating a new context for the modal, but it's worth studying it.

@elboletaire elboletaire added enhancement New feature or request chakra-components Things related to the chakra-components package labels Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chakra-components Things related to the chakra-components package enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant