chore(gh): update golangci-lint workflow

- Updates the GitHub Action for `golangci-lint`.
- Pin GitHub Actions to release commit SHA.

Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>

Author: tenthirtyam

.github/workflows/golangci-lint.yml

@@ -1,20 +1,32 @@
 name: golangci-lint
 
-on: [pull_request, push]
+on:
+  pull_request:
+    paths-ignore:
+      - 'README.md'
+  push:
+    paths-ignore:
+      - 'README.md'
+
+permissions:
+  contents: read
 
 jobs:
-  golangci:
-    name: lint
+  build:
+    name: Build
     runs-on: ubuntu-latest
+    timeout-minutes: 5
     steps:
-      - uses: actions/setup-go@v5
+      - name: Checkout
+        uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
+      - name: Setup Go
+        uses: actions/setup-go@41dfa10bad2bb2ae585af6ee5bb4d7d973ad74ed # v5.1.0
         with:
-          go-version: 1.19
-      - uses: actions/checkout@v4
-      - name: golangci-lint
-        uses: golangci/golangci-lint-action@v6
+          go-version-file: 'go.mod'
+          cache: true
+      - run: go mod download
+      - run: go build -v .
+      - name: Run Linters
+        uses: golangci/golangci-lint-action@971e284b6050e8a5849b72094c50ab08da042db8 # v6.1.1
         with:
-          version: v1.48.0
-          args: --issues-exit-code=1
-          only-new-issues: true
-          skip-cache: true
+          version: latest

.golangci.yml

@@ -1,17 +1,35 @@
-# https://github.com/golangci/golangci-lint#config-file
+# © Broadcom. All Rights Reserved.
+# The term “Broadcom” refers to Broadcom Inc. and/or its subsidiaries.
+# SPDX-License-Identifier: MPL-2.0
+
+# For more information about the golangci-lint configuration file, refer to:
+# https://golangci-lint.run/usage/configuration/
+
+issues:
+  exclude-rules:
+    - path: _test\.go
+      linters:
+        - dogsled
+        - funlen
+        - gocognit
+    - path: internal/authctx
+      linters:
+        - gosec
+        - nestif
+    - path: flatten_test.go
+      linters:
+        - dupl
 
 linters:
-  # please, do not use `enable-all`: it's deprecated and will be removed soon.
-  # inverted configuration with `enable-all` and `disable` is not scalable during updates of golangci-lint
   disable-all: true
   enable:
     - asciicheck
     - bodyclose
+    - copyloopvar
     - depguard
     - dogsled
     - dupl
     - errcheck
-    - exportloopref
     - funlen
     - goconst
     - gocognit
@@ -38,81 +56,47 @@ linters:
     - whitespace
     - wsl
 
-#   don't enable:
-#   - deadcode
-#   - exhaustive
-#   - gochecknoglobals
-#   - godox
-#   - gomnd
-#   - goerr113
-#   - gofumpt
-#   - interfacer
-#   - lll
-#   - maligned
-#   - nlreturn
-#   - noctx
-#   - nolintlint
-#   - rowserrcheck
-#   - scopelint
-#   - structcheck
-#   - testpackage
-#   - revive
-#   - varcheck
-
 run:
-  # include test files or not, default is true
-  tests: true
   deadline: 5m
   build-tags:
     - akscluster
     - cluster
     - clustergroup
+    - clustersecret
     - credential
+    - custompolicy
     - ekscluster
     - gitrepository
+    - helmfeature
+    - helmrelease
     - iampolicy
+    - imagepolicy
     - kustomization
+    - managementcluster
+    - mutationpolicy
     - namespace
-    - custompolicy
-    - imagepolicy
     - networkpolicy
+    - packageinstall
+    - packagerepository
+    - provisioner
     - quotapolicy
     - securitypolicy
     - sourcesecret
-    - workspace
-    - packageinstall
-    - packagerepository
-    - tanzupackages
     - tanzupackage
-    - clustersecret
-    - mutationpolicy
-    - helmfeature
-    - helmrelease
-    - managementcluster
-    - provisioner
+    - tanzupackages
+    - workspace
+
+output:
+  formats:
+    - format: colored-line-number
 
 linters-settings:
   funlen:
     lines: 150
     statements: 100
-  nestif:
-    min-complexity: 14
   gocognit:
     min-complexity: 60
   goimports:
     local-prefixes: github.com/vmware/terraform-provider-tanzu-mission-control
-
-issues:
-  exclude-rules:
-    - path: _test\.go
-      linters:
-        - dogsled
-        - funlen
-        - gocognit
-    - path: internal/authctx
-      linters:
-        - gosec
-        - nestif
-    - path: flatten_test.go
-      linters:
-        - dupl
+  nestif:
+    min-complexity: 14