Fix lint issues

Signed-off-by: Ishan Gupta <gishan@vmware.com>

Author: ishangupta-ds

internal/resources/tanzupackageinstall/package_install_datasource.go

@@ -13,6 +13,7 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 	"github.com/pkg/errors"
+
 	"github.com/vmware/terraform-provider-tanzu-mission-control/internal/authctx"
 	clienterrors "github.com/vmware/terraform-provider-tanzu-mission-control/internal/client/errors"
 	"github.com/vmware/terraform-provider-tanzu-mission-control/internal/resources/common"

internal/resources/tanzupackageinstall/package_install_resource.go

@@ -210,7 +210,7 @@ func resourcePackageInstallInPlaceUpdate(ctx context.Context, d *schema.Resource
 
 	if !updateAvailable {
 		log.Printf("[INFO] package install update is not required")
-		return
+		return diags
 	}
 
 	pkgInstallReq := &pkginstallclustermodel.VmwareTanzuManageV1alpha1ClusterNamespaceTanzupackageInstallInstallRequest{

internal/resources/tanzupackageinstall/package_install_resource_test.go

@@ -140,6 +140,7 @@ func TestAcceptanceForPackageInstallResource(t *testing.T) {
 	t.Log("package install resource acceptance test complete")
 }
 
+// nolint: unparam
 func (testConfig *testAcceptanceConfig) getTestPackageInstallResourceBasicConfigValue(scope commonscope.Scope, constraints string, inlineValuesFromFile bool) string {
 	helperBlock, _ := testConfig.ScopeHelperResources.GetTestResourceHelperAndScope(scope, packageinstallscope.ScopesAllowed[:])
 
@@ -238,6 +239,7 @@ func (testConfig *testAcceptanceConfig) getTestPackageInstallResourceBasicConfig
 		testConfig.Namespace, constraints, inlineValuesForPackageInstall)
 }
 
+// nolint: unparam
 // checkPackageInstallResourceAttributes checks for package install creation along with meta attributes.
 func (testConfig *testAcceptanceConfig) checkPackageInstallResourceAttributes(scopeType commonscope.Scope) resource.TestCheckFunc {
 	var check = []resource.TestCheckFunc{

internal/resources/tanzupackageinstall/spec/cluster_scope.go

@@ -151,8 +151,8 @@ func FlattenSpecForClusterScope(spec *packageinstallmodel.VmwareTanzuManageV1alp
 		flattenSpecData[InlineValuesKey] = spec.InlineValues
 	}
 
-	if v1, ok := spec.InlineValues.(interface{}); ok && pathToInlineValues != "" {
-		err = helper.WriteYamlFile(pathToInlineValues, v1)
+	if spec.InlineValues != nil && pathToInlineValues != "" {
+		err = helper.WriteYamlFile(pathToInlineValues, spec.InlineValues)
 		if err != nil {
 			return data, err
 		}

internal/resources/tanzupackageinstall/spec/spec.go

@@ -11,6 +11,7 @@ import (
 	"strings"
 
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
+
 	"github.com/vmware/terraform-provider-tanzu-mission-control/internal/helper"
 )
 

internal/resources/tanzupackageinstall/test_helper.go

@@ -19,27 +19,21 @@ import (
 
 // nolint: gosec
 const (
-	pkgRepoResource      = packagerepository.ResourceName
-	pkgRepoResourceVar   = "test_pkg_repository"
-	pkgRepoDataSourceVar = "test_data_source_pkg_repository"
-	pkgRepoNamePrefix    = "tf-pkg-repository-test"
+	pkgRepoResource    = packagerepository.ResourceName
+	pkgRepoResourceVar = "test_pkg_repository"
+	pkgRepoNamePrefix  = "tf-pkg-repository-test"
 
-	pkgInstallResource      = ResourceName
-	pkgInstallResourceVar   = "test_pkg_install"
-	pkgInstallDataSourceVar = "test_data_source_pkg_install"
-	pkgInstallNamePrefix    = "tf-pkg-install-test"
-	namespaceNamePrefix     = "test-pkg-install-ns"
+	pkgInstallResource    = ResourceName
+	pkgInstallResourceVar = "test_pkg_install"
+	pkgInstallNamePrefix  = "tf-pkg-install-test"
+	namespaceNamePrefix   = "test-pkg-install-ns"
 
 	constraints = "3.0.0-rc.1"
 
-	PkgResource         = ResourceName
-	pkgDataSourceVar    = "test_data_source_pkg"
 	pkgName1            = "2.0.0"
 	pkgName2            = "3.0.0-rc.1"
 	pkgMetadataName     = "pkg.test.carvel.dev"
 	globalRepoNamespace = "tanzu-package-repo-global"
-
-	imageURL = "projects.registry.vmware.com/tmc/build-integrations/package/repository/e2e-test-unauth-repo@sha256:87a5f7e0c44523fbc35a9432c657bebce246138bbd0f16d57f5615933ceef632"
 )
 
 type testAcceptanceConfig struct {