Skip to content

Commit 8aaa942

Browse files
committed
Make meta data converter mapping generic and populate provisioner meta info
Signed-off-by: Shobha M <mshobha@vmware.com>
1 parent aa47e00 commit 8aaa942

File tree

3 files changed

+16
-18
lines changed

3 files changed

+16
-18
lines changed

internal/resources/common/objectmeta_schema.go

+6-6
Original file line numberDiff line numberDiff line change
@@ -171,17 +171,17 @@ func GetTypeIntMapData(data map[string]interface{}) map[string]int {
171171
}
172172

173173
// GetMetaConverterMap returns mapping for converter.
174-
func GetMetaConverterMap(modelPathSeparator string) *converter.BlockToStruct {
174+
func GetMetaConverterMap(modelPathSeparator string, modelPath ...string) *converter.BlockToStruct {
175175
var MetaConverterMap = &converter.BlockToStruct{
176176
AnnotationsKey: &converter.Map{
177-
converter.AllMapKeysFieldMarker: converter.BuildModelPath(modelPathSeparator, "meta", "annotations", converter.AllMapKeysFieldMarker),
177+
converter.AllMapKeysFieldMarker: converter.BuildModelPath(modelPathSeparator, append(modelPath, "meta", "annotations", converter.AllMapKeysFieldMarker)...),
178178
},
179179
LabelsKey: &converter.Map{
180-
converter.AllMapKeysFieldMarker: converter.BuildModelPath(modelPathSeparator, "meta", "labels", converter.AllMapKeysFieldMarker),
180+
converter.AllMapKeysFieldMarker: converter.BuildModelPath(modelPathSeparator, append(modelPath, "meta", "labels", converter.AllMapKeysFieldMarker)...),
181181
},
182-
DescriptionKey: converter.BuildModelPath(modelPathSeparator, "meta", "description"),
183-
resourceVersionKey: converter.BuildModelPath(modelPathSeparator, "meta", "resourceVersion"),
184-
uidKey: converter.BuildModelPath(modelPathSeparator, "meta", "uid"),
182+
DescriptionKey: converter.BuildModelPath(modelPathSeparator, append(modelPath, "meta", "description")...),
183+
resourceVersionKey: converter.BuildModelPath(modelPathSeparator, append(modelPath, "meta", "resourceVersion")...),
184+
uidKey: converter.BuildModelPath(modelPathSeparator, append(modelPath, "meta", "uid")...),
185185
}
186186

187187
return MetaConverterMap

internal/resources/provisioner/converter_mapping.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ var tfDataModelMap = &tfModelConverterHelper.BlockToStruct{
2424
{
2525
managementClusterNameKey: tfModelConverterHelper.BuildDefaultModelPath(provisionerArrayField, "fullName", "managementClusterName"),
2626
nameKey: tfModelConverterHelper.BuildDefaultModelPath(provisionerArrayField, "fullName", "name"),
27-
common.MetaKey: common.GetMetaConverterMap(tfModelConverterHelper.DefaultModelPathSeparator),
27+
common.MetaKey: common.GetMetaConverterMap(tfModelConverterHelper.DefaultModelPathSeparator, provisionerArrayField),
2828
},
2929
},
3030
}

internal/resources/provisioner/provisioner_data_source_test.go

+9-11
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,7 @@ func checkDataSourceAttributes(dataSourceName, resourceName string) resource.Tes
6767
resource.TestCheckResourceAttrSet(dataSourceName, "id"),
6868
}
6969

70-
// TODO: Add the meta check after TMC-54016 fix.
71-
// check = append(check, metaDataSourceAttributeCheck(dataSourceName, resourceName)...)
70+
check = append(check, metaDataSourceAttributeCheck(dataSourceName, resourceName)...)
7271

7372
return resource.ComposeTestCheckFunc(check...)
7473
}
@@ -84,12 +83,11 @@ func verifyProvisionerDataSource(name string) resource.TestCheckFunc {
8483
}
8584
}
8685

87-
// TODO: Add the meta check after TMC-54016 fix.
88-
// func metaDataSourceAttributeCheck(dataSourceName, resourceName string) []resource.TestCheckFunc {
89-
// return []resource.TestCheckFunc{
90-
// resource.TestCheckResourceAttrPair(dataSourceName, "meta.0.description", resourceName, "meta.0.description"),
91-
// resource.TestCheckResourceAttrPair(dataSourceName, "meta.0.labels.key1", resourceName, "meta.0.labels.key1"),
92-
// resource.TestCheckResourceAttrPair(dataSourceName, "meta.0.labels.key2", resourceName, "meta.0.labels.key2"),
93-
// resource.TestCheckResourceAttrSet(dataSourceName, "meta.0.uid"),
94-
// }
95-
//}
86+
func metaDataSourceAttributeCheck(dataSourceName, resourceName string) []resource.TestCheckFunc {
87+
return []resource.TestCheckFunc{
88+
resource.TestCheckResourceAttrPair(dataSourceName, "provisioners.0.meta.0.description", resourceName, "meta.0.description"),
89+
resource.TestCheckResourceAttrPair(dataSourceName, "provisioners.0.meta.0.labels.key1", resourceName, "meta.0.labels.key1"),
90+
resource.TestCheckResourceAttrPair(dataSourceName, "provisioners.0.meta.0.labels.key2", resourceName, "meta.0.labels.key2"),
91+
resource.TestCheckResourceAttrSet(dataSourceName, "provisioners.0.meta.0.uid"),
92+
}
93+
}

0 commit comments

Comments
 (0)