fix linting

Signed-off-by: Will Arroyo <warroyo7199008@gmail.com>

Author: warroyo

internal/resources/kubernetessecret/data_source_secret.go

@@ -79,11 +79,13 @@ func dataSourceSecretRead(ctx context.Context, d *schema.ResourceData, m interfa
 	d.SetId(secretDataFromServer.UID)
 
 	var password string
+
 	var opaqueData map[string]interface{}
 
 	if _, ok := d.GetOk(helper.GetFirstElementOf(spec.SpecKey, spec.DockerConfigjsonKey, spec.PasswordKey)); ok {
 		password, _ = (d.Get(helper.GetFirstElementOf(spec.SpecKey, spec.DockerConfigjsonKey, spec.PasswordKey))).(string)
 	}
+
 	if opData, ok := d.GetOk(helper.GetFirstElementOf(spec.SpecKey, spec.OpaqueKey)); ok && opData != nil {
 		opaqueData = opData.(map[string]interface{})
 	}

internal/resources/kubernetessecret/resource_secret.go

@@ -280,8 +280,7 @@ func resourceSecretInPlaceUpdate(ctx context.Context, d *schema.ResourceData, m
 		return diag.Errorf("updating %v is not possible", spec.ImageRegistryURLKey)
 	}
 
-	if updateCheckForMeta(d, secretDataFromServer.meta) || updateCheckForSpec(ctx, d, secretDataFromServer.atomicSpec, scopedFullnameData.Scope) {
-
+	if updateCheckForMeta(d, secretDataFromServer.meta) || updateCheckForSpec(d, secretDataFromServer.atomicSpec, scopedFullnameData.Scope) {
 		switch scopedFullnameData.Scope {
 		case commonscope.ClusterScope:
 			if scopedFullnameData.FullnameCluster != nil {
@@ -330,8 +329,7 @@ func resourceSecretInPlaceUpdate(ctx context.Context, d *schema.ResourceData, m
 	return dataSourceSecretRead(ctx, d, m)
 }
 
-func updateCheckForSpec(ctx context.Context, d *schema.ResourceData, atomicSpec *clustersecretmodel.VmwareTanzuManageV1alpha1ClusterNamespaceSecretSpec, scope commonscope.Scope) bool {
-
+func updateCheckForSpec(d *schema.ResourceData, atomicSpec *clustersecretmodel.VmwareTanzuManageV1alpha1ClusterNamespaceSecretSpec, scope commonscope.Scope) bool {
 	if !(spec.HasSpecChanged(d)) {
 		username := d.Get(helper.GetFirstElementOf(spec.SpecKey, spec.DockerConfigjsonKey, spec.UsernameKey))
 		password := d.Get(helper.GetFirstElementOf(spec.SpecKey, spec.DockerConfigjsonKey, spec.PasswordKey))

internal/resources/kubernetessecret/spec/cluster_scope.go

@@ -33,7 +33,6 @@ func ConstructSpecForClusterScope(d *schema.ResourceData) (spec *secretmodel.Vmw
 
 	specData := data[0].(map[string]interface{})
 	if v, ok := specData[DockerConfigjsonKey]; ok {
-
 		if v1, ok := v.([]interface{}); ok && len(v1) != 0 {
 			spec.SecretType = secretmodel.NewVmwareTanzuManageV1alpha1ClusterNamespaceSecretType(secretmodel.VmwareTanzuManageV1alpha1ClusterNamespaceSecretTypeSECRETTYPEDOCKERCONFIGJSON)
 
@@ -65,15 +64,13 @@ func ConstructSpecForClusterScope(d *schema.ResourceData) (spec *secretmodel.Vmw
 	}
 
 	if v, ok := specData[OpaqueKey]; ok {
-
 		opaqueData := common.GetTypeStringMapData(v.(map[string]interface{}))
 		if len(opaqueData) != 0 {
 			spec.SecretType = secretmodel.NewVmwareTanzuManageV1alpha1ClusterNamespaceSecretType(secretmodel.VmwareTanzuManageV1alpha1ClusterNamespaceSecretTypeSECRETTYPEOPAQUE)
 
 			encodedData := getEncodedOpaqueData(opaqueData)
 			spec.Data = encodedData
 		}
-
 	}
 
 	return spec
@@ -83,6 +80,7 @@ func FlattenSpecForClusterScope(spec *secretmodel.VmwareTanzuManageV1alpha1Clust
 	if spec == nil {
 		return data
 	}
+
 	flattenSpecData := make(map[string]interface{})
 
 	if *spec.SecretType == *secretmodel.NewVmwareTanzuManageV1alpha1ClusterNamespaceSecretType(secretmodel.VmwareTanzuManageV1alpha1ClusterNamespaceSecretTypeSECRETTYPEDOCKERCONFIGJSON) {
@@ -119,7 +117,6 @@ func FlattenSpecForClusterScope(spec *secretmodel.VmwareTanzuManageV1alpha1Clust
 	}
 
 	if *spec.SecretType == *secretmodel.NewVmwareTanzuManageV1alpha1ClusterNamespaceSecretType(secretmodel.VmwareTanzuManageV1alpha1ClusterNamespaceSecretTypeSECRETTYPEOPAQUE) {
-
 		flattenSpecData[OpaqueKey] = opaqueData
 	}
 

internal/resources/kubernetessecret/spec/spec.go

@@ -129,20 +129,21 @@ func ValidateInput(ctx context.Context, diff *schema.ResourceDiff, i interface{}
 					secretTypesFound = append(secretTypesFound, secret)
 				}
 			}
+
 			if secret == DockerConfigjsonKey {
 				converted := secretData.([]interface{})
 				if len(converted) != 0 {
 					secretTypesFound = append(secretTypesFound, secret)
 				}
 			}
-
 		}
 	}
 
 	if len(secretTypesFound) == 0 {
-		return fmt.Errorf("no valid spec block found: minimum one valid secret block is required among: %v", strings.Join(secretTypes[:], `, `))
+		return fmt.Errorf("no valid spec block found: minimum one valid secret block is required among: %v", strings.Join(secretTypes, `, `))
 	} else if len(secretTypesFound) > 1 {
 		return fmt.Errorf("found secret blocks: %v are not valid: maximum one valid secret block is allowed", strings.Join(secretTypesFound, `, `))
 	}
+
 	return nil
 }