Add provisioner mock test and test tag

Signed-off-by: Shobha M <mshobha@vmware.com>

Author: shobha2626

.github/workflows/release.yml

@@ -6,7 +6,7 @@ on:
       - 'v*'
 
 env:
-  BUILD_TAGS: 'akscluster cluster clustergroup credential ekscluster gitrepository iampolicy kustomization namespace custompolicy imagepolicy networkpolicy quotapolicy securitypolicy sourcesecret workspace tanzupackage tanzupackages packagerepository packageinstall clustersecret integration mutationpolicy backupschedule targetlocation dataprotection tanzukubernetescluster clusterclass managementcluster'
+  BUILD_TAGS: 'akscluster cluster clustergroup credential ekscluster gitrepository iampolicy kustomization namespace custompolicy imagepolicy networkpolicy quotapolicy securitypolicy sourcesecret workspace tanzupackage tanzupackages packagerepository packageinstall clustersecret integration mutationpolicy backupschedule targetlocation dataprotection tanzukubernetescluster clusterclass managementcluster provisioner'
 
 jobs:
   goreleaser:

.github/workflows/test.yml

@@ -3,7 +3,7 @@ name: Test and coverage
 on: [pull_request, push]
 
 env:
-  BUILD_TAGS: 'akscluster cluster clustergroup credential ekscluster gitrepository iampolicy kustomization namespace custompolicy imagepolicy networkpolicy quotapolicy securitypolicy sourcesecret workspace tanzupackage tanzupackages packagerepository packageinstall clustersecret integration mutationpolicy backupschedule targetlocation dataprotection tanzukubernetescluster clusterclass managementcluster'
+  BUILD_TAGS: 'akscluster cluster clustergroup credential ekscluster gitrepository iampolicy kustomization namespace custompolicy imagepolicy networkpolicy quotapolicy securitypolicy sourcesecret workspace tanzupackage tanzupackages packagerepository packageinstall clustersecret integration mutationpolicy backupschedule targetlocation dataprotection tanzukubernetescluster clusterclass managementcluster provisioner'
 jobs:
   build:
     name: Test and coverage

.golangci.yml

@@ -89,6 +89,7 @@ run:
     - helmfeature
     - helmrelease
     - managementcluster
+    - provisioner
 
 linters-settings:
   funlen:

Makefile

@@ -22,7 +22,7 @@ ifeq ($(TEST_FLAGS),)
 endif
 
 ifeq ($(BUILD_TAGS),)
-	BUILD_TAGS := 'akscluster cluster clustergroup credential ekscluster gitrepository iampolicy kustomization namespace custompolicy imagepolicy networkpolicy quotapolicy securitypolicy sourcesecret workspace tanzupackage tanzupackages packagerepository packageinstall clustersecret integration mutationpolicy helmfeature helmrelease backupschedule targetlocation dataprotection tanzukubernetescluster clusterclass managementcluster'
+	BUILD_TAGS := 'akscluster cluster clustergroup credential ekscluster gitrepository iampolicy kustomization namespace custompolicy imagepolicy networkpolicy quotapolicy securitypolicy sourcesecret workspace tanzupackage tanzupackages packagerepository packageinstall clustersecret integration mutationpolicy helmfeature helmrelease backupschedule targetlocation dataprotection tanzukubernetescluster clusterclass managementcluster provisioner'
 endif
 
 .PHONY: build clean-up test gofmt vet lint acc-test website-lint website-lint-fix

internal/resources/provisioner/provisioner_mock_test.go

@@ -1 +1,166 @@
+/*
+Copyright © 2023 VMware, Inc. All Rights Reserved.
+SPDX-License-Identifier: MPL-2.0
+*/
+
 package provisioner
+
+import (
+	"encoding/json"
+	"fmt"
+	"io"
+	"net/http"
+	"os"
+	"testing"
+
+	"github.com/go-test/deep"
+	"github.com/jarcoal/httpmock"
+
+	"github.com/vmware/terraform-provider-tanzu-mission-control/internal/helper"
+	objectmetamodel "github.com/vmware/terraform-provider-tanzu-mission-control/internal/models/objectmeta"
+	provisionermodel "github.com/vmware/terraform-provider-tanzu-mission-control/internal/models/provisioner"
+)
+
+func setupHTTPMocks(t *testing.T) {
+	httpmock.Activate()
+	t.Cleanup(httpmock.Deactivate)
+}
+
+const (
+	https        = "https:/"
+	apiVersion   = "v1alpha1"
+	mgmtClusters = "managementclusters"
+	provisioners = "provisioners"
+)
+
+func setUpProvisionerEndPointMocks(t *testing.T, endpoint, prvName string) {
+	provisionerRequest := &provisionermodel.VmwareTanzuManageV1alpha1ManagementclusterProvisionerCreateProvisionerRequest{}
+
+	provisionerResponse := &provisionermodel.VmwareTanzuManageV1alpha1ManagementclusterProvisionerCreateProvisionerResponse{
+		Provisioner: &provisionermodel.VmwareTanzuManageV1alpha1ManagementclusterProvisionerProvisioner{
+			FullName: &provisionermodel.VmwareTanzuManageV1alpha1ManagementclusterProvisionerFullName{
+				ManagementClusterName: eksManagementCluster,
+				Name:                  prvName,
+			},
+			Meta: &objectmetamodel.VmwareTanzuCoreV1alpha1ObjectMeta{
+				Description: "resource with description",
+				Labels: map[string]string{
+					"key1": "value1",
+					"key2": "value2",
+				},
+				UID:             "dummy-uid-1234",
+				ResourceVersion: "res-version",
+			},
+		},
+	}
+
+	createProvisionerEndpoint := helper.ConstructRequestURL(https, endpoint, apiVersion, mgmtClusters, eksManagementCluster, provisioners).String()
+	readProvisionerEndpoint := helper.ConstructRequestURL(https, endpoint, apiVersion, mgmtClusters, eksManagementCluster, provisioners, prvName).String()
+	deleteProvisionerEndpoint := helper.ConstructRequestURL(https, endpoint, apiVersion, mgmtClusters, eksManagementCluster, provisioners, prvName).String()
+
+	httpmock.RegisterResponder("POST", createProvisionerEndpoint,
+		bodyInspectingResponder(t, provisionerRequest, http.StatusOK, provisionerResponse))
+
+	httpmock.RegisterResponder("GET", readProvisionerEndpoint,
+		bodyInspectingResponder(t, nil, http.StatusOK, provisionerResponse))
+
+	httpmock.RegisterResponder("PUT", readProvisionerEndpoint,
+		bodyInspectingResponder(t, nil, http.StatusOK, provisionerResponse))
+
+	httpmock.RegisterResponder("GET", readProvisionerEndpoint,
+		bodyInspectingResponder(t, nil, http.StatusOK, provisionerResponse))
+
+	httpmock.RegisterResponder("DELETE", deleteProvisionerEndpoint, changeStateResponder(
+		func() {
+			httpmock.RegisterResponder("GET", readProvisionerEndpoint,
+				httpmock.NewStringResponder(http.StatusBadRequest, "Not found"))
+		},
+		http.StatusOK,
+		nil))
+}
+
+func setUpHTTPMockUpdate(t *testing.T, prvName string) {
+	endpoint := os.Getenv("TMC_ENDPOINT")
+
+	provisionerResponse := &provisionermodel.VmwareTanzuManageV1alpha1ManagementclusterProvisionerCreateProvisionerResponse{
+		Provisioner: &provisionermodel.VmwareTanzuManageV1alpha1ManagementclusterProvisionerProvisioner{
+			FullName: &provisionermodel.VmwareTanzuManageV1alpha1ManagementclusterProvisionerFullName{
+				ManagementClusterName: eksManagementCluster,
+				Name:                  prvName,
+			},
+			Meta: &objectmetamodel.VmwareTanzuCoreV1alpha1ObjectMeta{
+				Description: "resource with updated description",
+				Labels: map[string]string{
+					"key1": "value1",
+					"key2": "value2",
+					"key3": "value3",
+				},
+				UID:             "dummy-uid-1234",
+				ResourceVersion: "res-version",
+			},
+		},
+	}
+
+	readProvisionerEndpoint := helper.ConstructRequestURL(https, endpoint, apiVersion, mgmtClusters, eksManagementCluster, provisioners, prvName).String()
+
+	httpmock.RegisterResponder("GET", readProvisionerEndpoint,
+		bodyInspectingResponder(t, nil, 200, provisionerResponse))
+}
+
+//nolint:unparam
+func bodyInspectingResponder(t *testing.T, expectedContent interface{}, successResponse int, successResponseBody interface{}) httpmock.Responder {
+	return func(r *http.Request) (*http.Response, error) {
+		successFunc := func() (*http.Response, error) {
+			return httpmock.NewJsonResponse(successResponse, successResponseBody)
+		}
+
+		if expectedContent == nil {
+			return successFunc()
+		}
+
+		// Compare to expected content.
+		expectedBytes, err := json.Marshal(expectedContent)
+		if err != nil {
+			t.Fail()
+			return nil, err
+		}
+
+		if r.Body == nil {
+			t.Fail()
+			return nil, fmt.Errorf("expected body on request")
+		}
+
+		bodyBytes, err := io.ReadAll(r.Body)
+		if err != nil {
+			t.Fail()
+			return nil, err
+		}
+
+		var bodyInterface map[string]interface{}
+		if err = json.Unmarshal(bodyBytes, &bodyInterface); err == nil {
+			var expectedInterface map[string]interface{}
+
+			err = json.Unmarshal(expectedBytes, &expectedInterface)
+			if err != nil {
+				return nil, err
+			}
+
+			diff := deep.Equal(bodyInterface, expectedInterface)
+			if diff == nil {
+				return successFunc()
+			}
+		} else {
+			return nil, err
+		}
+
+		return successFunc()
+	}
+}
+
+// Register a new responder when the given call is made.
+func changeStateResponder(registerFunc func(), successResponse int, successResponseBody interface{}) httpmock.Responder {
+	return func(r *http.Request) (*http.Response, error) {
+		registerFunc()
+		return httpmock.NewJsonResponse(successResponse, successResponseBody)
+	}
+}

internal/resources/provisioner/provisioner_provider_test.go

@@ -9,8 +9,11 @@ SPDX-License-Identifier: MPL-2.0
 package provisioner
 
 import (
+	"context"
+	"os"
 	"testing"
 
+	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 	"github.com/stretchr/testify/require"
 
@@ -26,11 +29,19 @@ func initTestProvider(t *testing.T) *schema.Provider {
 		DataSourcesMap: map[string]*schema.Resource{
 			ResourceName: DataSourceProvisioner(),
 		},
-		ConfigureContextFunc: authctx.ProviderConfigureContext,
+		ConfigureContextFunc: getConfigureContextFunc(),
 	}
 	if err := testAccProvider.InternalValidate(); err != nil {
 		require.NoError(t, err)
 	}
 
 	return testAccProvider
 }
+
+func getConfigureContextFunc() func(_ context.Context, d *schema.ResourceData) (interface{}, diag.Diagnostics) {
+	if _, found := os.LookupEnv("ENABLE_PROVISIONER_ENV_TEST"); !found {
+		return authctx.ProviderConfigureContextWithDefaultTransportForTesting
+	}
+
+	return authctx.ProviderConfigureContext
+}

internal/resources/provisioner/provisioner_resource_test.go

@@ -21,7 +21,7 @@ import (
 
 	"github.com/vmware/terraform-provider-tanzu-mission-control/internal/authctx"
 	"github.com/vmware/terraform-provider-tanzu-mission-control/internal/client/proxy"
-	provisioner "github.com/vmware/terraform-provider-tanzu-mission-control/internal/models/provisioner"
+	provisionermodel "github.com/vmware/terraform-provider-tanzu-mission-control/internal/models/provisioner"
 	testhelper "github.com/vmware/terraform-provider-tanzu-mission-control/internal/resources/testing"
 )
 
@@ -31,6 +31,32 @@ func TestAcceptanceForProvisionerResource(t *testing.T) {
 	provisionerResourceName := fmt.Sprintf("%s.%s", ResourceName, resourceVar)
 	provisionerName := acctest.RandomWithPrefix("tf-prv-test")
 
+	_, enableProvisionerEnvTest := os.LookupEnv("ENABLE_PROVISIONER_ENV_TEST")
+
+	if !enableProvisionerEnvTest {
+		endpoint := "play.abc.def.ghi.com"
+
+		os.Setenv("TF_ACC", "true")
+		os.Setenv(authctx.ServerEndpointEnvVar, endpoint)
+		os.Setenv("VMW_CLOUD_API_TOKEN", "dummy")
+		os.Setenv("VMW_CLOUD_ENDPOINT", "console.cloud.vmware.com")
+
+		setupHTTPMocks(t)
+		setUpProvisionerEndPointMocks(t, endpoint, provisionerName)
+	} else {
+		requiredVars := []string{
+			"VMW_CLOUD_ENDPOINT",
+			"TMC_ENDPOINT",
+			"VMW_CLOUD_API_TOKEN",
+		}
+
+		for _, name := range requiredVars {
+			if _, found := os.LookupEnv(name); !found {
+				t.Errorf("required environment variable '%s' missing", name)
+			}
+		}
+	}
+
 	resource.Test(t, resource.TestCase{
 		PreCheck:          testhelper.TestPreCheck(t),
 		ProviderFactories: testhelper.GetTestProviderFactories(provider),
@@ -43,6 +69,13 @@ func TestAcceptanceForProvisionerResource(t *testing.T) {
 				),
 			},
 			{
+				PreConfig: func() {
+					if !enableProvisionerEnvTest {
+						t.Log("Setting up the updated GET mock responder...")
+						setupHTTPMocks(t)
+						setUpHTTPMockUpdate(t, provisionerName)
+					}
+				},
 				Config: updateTestProvisionerWithResourceConfigValue(provisionerName),
 				Check: resource.ComposeTestCheckFunc(
 					checkUpdateResourceAttributes(provider, provisionerResourceName, provisionerName),
@@ -118,20 +151,20 @@ func verifyProvisionerResourceCreation(
 			return fmt.Errorf("ID not set, resource: %s", resourceName)
 		}
 
-		config := authctx.TanzuContext{
+		config := &authctx.TanzuContext{
 			ServerEndpoint:   os.Getenv(authctx.ServerEndpointEnvVar),
 			Token:            os.Getenv(authctx.VMWCloudAPITokenEnvVar),
 			VMWCloudEndPoint: os.Getenv(authctx.VMWCloudEndpointEnvVar),
 			TLSConfig:        &proxy.TLSConfig{},
 		}
 
-		err := config.Setup()
+		err := getSetupConfig(config)
 		if err != nil {
 			return errors.Wrap(err, "unable to set the context")
 		}
 
-		fn := &provisioner.VmwareTanzuManageV1alpha1ManagementclusterProvisionerFullName{
-			ManagementClusterName: "eks",
+		fn := &provisionermodel.VmwareTanzuManageV1alpha1ManagementclusterProvisionerFullName{
+			ManagementClusterName: eksManagementCluster,
 			Name:                  provisionerName,
 		}
 
@@ -148,6 +181,14 @@ func verifyProvisionerResourceCreation(
 	}
 }
 
+func getSetupConfig(config *authctx.TanzuContext) error {
+	if _, found := os.LookupEnv("ENABLE_PROVISIONER_ENV_TEST"); !found {
+		return config.SetupWithDefaultTransportForTesting()
+	}
+
+	return config.Setup()
+}
+
 func metaResourceAttributeCheck(resourceName string) []resource.TestCheckFunc {
 	return []resource.TestCheckFunc{
 		resource.TestCheckResourceAttr(resourceName, "meta.#", "1"),