Skip to content

Commit fbbc44c

Browse files
esteveesteve
authored
refactor(stop_filter): prefix package and namespace with autoware (autowarefoundation#7789)
* refactor(stop_filter): prefix package and namespace with autoware Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp> * fix launch files and update CODEOWNERS Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp> --------- Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
1 parent 82d86dc commit fbbc44c

File tree

10 files changed

+18
-11
lines changed

10 files changed

+18
-11
lines changed

‎.github/CODEOWNERS

+1-1
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ launch/tier4_vehicle_launch/** yukihiro.saito@tier4.jp
8181
localization/autoware_landmark_based_localizer/autoware_ar_tag_based_localizer/** anh.nguyen.2@tier4.jp kento.yabuuchi.2@tier4.jp masahiro.sakamoto@tier4.jp ryu.yamamoto@tier4.jp shintaro.sakoda@tier4.jp taiki.yamada@tier4.jp yamato.ando@tier4.jp
8282
localization/autoware_landmark_based_localizer/autoware_landmark_manager/** anh.nguyen.2@tier4.jp kento.yabuuchi.2@tier4.jp masahiro.sakamoto@tier4.jp ryu.yamamoto@tier4.jp shintaro.sakoda@tier4.jp taiki.yamada@tier4.jp yamato.ando@tier4.jp
8383
localization/autoware_pose_covariance_modifier/** melike@leodrive.ai
84+
localization/autoware_stop_filter/** anh.nguyen.2@tier4.jp kento.yabuuchi.2@tier4.jp koji.minoda@tier4.jp masahiro.sakamoto@tier4.jp ryu.yamamoto@tier4.jp shintaro.sakoda@tier4.jp taiki.yamada@tier4.jp yamato.ando@tier4.jp
8485
localization/ekf_localizer/** anh.nguyen.2@tier4.jp kento.yabuuchi.2@tier4.jp koji.minoda@tier4.jp masahiro.sakamoto@tier4.jp ryu.yamamoto@tier4.jp shintaro.sakoda@tier4.jp taiki.yamada@tier4.jp takamasa.horibe@tier4.jp takeshi.ishita@tier4.jp yamato.ando@tier4.jp
8586
localization/geo_pose_projector/** anh.nguyen.2@tier4.jp kento.yabuuchi.2@tier4.jp koji.minoda@tier4.jp masahiro.sakamoto@tier4.jp ryu.yamamoto@tier4.jp shintaro.sakoda@tier4.jp taiki.yamada@tier4.jp yamato.ando@tier4.jp
8687
localization/gyro_odometer/** anh.nguyen.2@tier4.jp kento.yabuuchi.2@tier4.jp masahiro.sakamoto@tier4.jp ryu.yamamoto@tier4.jp shintaro.sakoda@tier4.jp taiki.yamada@tier4.jp yamato.ando@tier4.jp
@@ -91,7 +92,6 @@ localization/pose2twist/** anh.nguyen.2@tier4.jp kento.yabuuchi.2@tier4.jp masah
9192
localization/pose_estimator_arbiter/** anh.nguyen.2@tier4.jp kento.yabuuchi.2@tier4.jp masahiro.sakamoto@tier4.jp ryu.yamamoto@tier4.jp shintaro.sakoda@tier4.jp taiki.yamada@tier4.jp yamato.ando@tier4.jp
9293
localization/pose_initializer/** anh.nguyen.2@tier4.jp isamu.takagi@tier4.jp kento.yabuuchi.2@tier4.jp masahiro.sakamoto@tier4.jp ryu.yamamoto@tier4.jp shintaro.sakoda@tier4.jp taiki.yamada@tier4.jp yamato.ando@tier4.jp
9394
localization/pose_instability_detector/** anh.nguyen.2@tier4.jp kento.yabuuchi.2@tier4.jp masahiro.sakamoto@tier4.jp ryu.yamamoto@tier4.jp shintaro.sakoda@tier4.jp taiki.yamada@tier4.jp yamato.ando@tier4.jp
94-
localization/stop_filter/** anh.nguyen.2@tier4.jp kento.yabuuchi.2@tier4.jp koji.minoda@tier4.jp masahiro.sakamoto@tier4.jp ryu.yamamoto@tier4.jp shintaro.sakoda@tier4.jp taiki.yamada@tier4.jp yamato.ando@tier4.jp
9595
localization/twist2accel/** anh.nguyen.2@tier4.jp kento.yabuuchi.2@tier4.jp koji.minoda@tier4.jp masahiro.sakamoto@tier4.jp ryu.yamamoto@tier4.jp shintaro.sakoda@tier4.jp taiki.yamada@tier4.jp yamato.ando@tier4.jp
9696
localization/yabloc/yabloc_common/** anh.nguyen.2@tier4.jp kento.yabuuchi.2@tier4.jp masahiro.sakamoto@tier4.jp ryu.yamamoto@tier4.jp shintaro.sakoda@tier4.jp taiki.yamada@tier4.jp yamato.ando@tier4.jp
9797
localization/yabloc/yabloc_image_processing/** anh.nguyen.2@tier4.jp kento.yabuuchi.2@tier4.jp masahiro.sakamoto@tier4.jp ryu.yamamoto@tier4.jp shintaro.sakoda@tier4.jp taiki.yamada@tier4.jp yamato.ando@tier4.jp

‎launch/tier4_localization_launch/launch/pose_twist_fusion_filter/pose_twist_fusion_filter.launch.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
</group>
1818

1919
<group>
20-
<include file="$(find-pkg-share stop_filter)/launch/stop_filter.launch.xml">
20+
<include file="$(find-pkg-share autoware_stop_filter)/launch/stop_filter.launch.xml">
2121
<arg name="use_twist_with_covariance" value="True"/>
2222
<arg name="input_odom_name" value="/localization/pose_twist_fusion_filter/kinematic_state"/>
2323
<arg name="input_twist_with_covariance_name" value="/localization/pose_twist_fusion_filter/twist_with_covariance"/>

‎localization/stop_filter/CMakeLists.txt ‎localization/autoware_stop_filter/CMakeLists.txt

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
11
cmake_minimum_required(VERSION 3.14)
2-
project(stop_filter)
2+
project(autoware_stop_filter)
33

44
find_package(autoware_cmake REQUIRED)
55
autoware_package()
66

77
ament_auto_add_library(${PROJECT_NAME} SHARED
88
src/stop_filter.cpp
9+
src/stop_filter.hpp
910
)
1011

1112
rclcpp_components_register_node(${PROJECT_NAME}

‎localization/stop_filter/README.md ‎localization/autoware_stop_filter/README.md

File renamed without changes.

‎localization/stop_filter/config/stop_filter.param.yaml ‎localization/autoware_stop_filter/config/stop_filter.param.yaml

File renamed without changes.

‎localization/stop_filter/launch/stop_filter.launch.xml ‎localization/autoware_stop_filter/launch/stop_filter.launch.xml

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
<launch>
2-
<arg name="param_path" default="$(find-pkg-share stop_filter)/config/stop_filter.param.yaml"/>
2+
<arg name="param_path" default="$(find-pkg-share autoware_stop_filter)/config/stop_filter.param.yaml"/>
33
<arg name="input_odom_name" default="ekf_odom"/>
44
<arg name="output_odom_name" default="stop_filter_odom"/>
55
<arg name="debug_stop_flag" default="debug/stop_flag"/>
6-
<node pkg="stop_filter" exec="stop_filter_node" output="both">
6+
<node pkg="autoware_stop_filter" exec="autoware_stop_filter_node" output="both">
77
<remap from="input/odom" to="$(var input_odom_name)"/>
88

99
<remap from="output/odom" to="$(var output_odom_name)"/>

‎localization/stop_filter/package.xml ‎localization/autoware_stop_filter/package.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?xml version="1.0"?>
22
<?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
33
<package format="3">
4-
<name>stop_filter</name>
4+
<name>autoware_stop_filter</name>
55
<version>0.0.0</version>
66
<description>The stop filter package</description>
77
<maintainer email="koji.minoda@tier4.jp">Koji Minoda</maintainer>

‎localization/stop_filter/schema/stop_filter.schema.json ‎localization/autoware_stop_filter/schema/stop_filter.schema.json

File renamed without changes.

‎localization/stop_filter/src/stop_filter.cpp ‎localization/autoware_stop_filter/src/stop_filter.cpp

+5-2
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
1414

15-
#include "stop_filter/stop_filter.hpp"
15+
#include "stop_filter.hpp"
1616

1717
#include <rclcpp/logging.hpp>
1818

@@ -24,6 +24,8 @@
2424

2525
using std::placeholders::_1;
2626

27+
namespace autoware::stop_filter
28+
{
2729
StopFilter::StopFilter(const rclcpp::NodeOptions & node_options)
2830
: rclcpp::Node("stop_filter", node_options)
2931
{
@@ -57,6 +59,7 @@ void StopFilter::callback_odometry(const nav_msgs::msg::Odometry::SharedPtr msg)
5759
pub_stop_flag_->publish(stop_flag_msg);
5860
pub_odom_->publish(odom_msg);
5961
}
62+
} // namespace autoware::stop_filter
6063

6164
#include <rclcpp_components/register_node_macro.hpp>
62-
RCLCPP_COMPONENTS_REGISTER_NODE(StopFilter)
65+
RCLCPP_COMPONENTS_REGISTER_NODE(autoware::stop_filter::StopFilter)

‎localization/stop_filter/include/stop_filter/stop_filter.hpp ‎localization/autoware_stop_filter/src/stop_filter.hpp

+6-3
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
1414

15-
#ifndef STOP_FILTER__STOP_FILTER_HPP_
16-
#define STOP_FILTER__STOP_FILTER_HPP_
15+
#ifndef STOP_FILTER_HPP_
16+
#define STOP_FILTER_HPP_
1717

1818
#include <rclcpp/rclcpp.hpp>
1919

@@ -34,6 +34,8 @@
3434
#include <string>
3535
#include <vector>
3636

37+
namespace autoware::stop_filter
38+
{
3739
class StopFilter : public rclcpp::Node
3840
{
3941
public:
@@ -54,4 +56,5 @@ class StopFilter : public rclcpp::Node
5456
*/
5557
void callback_odometry(const nav_msgs::msg::Odometry::SharedPtr msg);
5658
};
57-
#endif // STOP_FILTER__STOP_FILTER_HPP_
59+
} // namespace autoware::stop_filter
60+
#endif // STOP_FILTER_HPP_

0 commit comments

Comments
 (0)