From ddf4b20fa1d11ec982c3cb52e9f272e32b8116f5 Mon Sep 17 00:00:00 2001 From: Denise Buder Date: Mon, 10 Jun 2024 14:25:42 +0200 Subject: [PATCH] Check for valid sender defensively --- packages/api/src/brevo-config/brevo-config.resolver.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/api/src/brevo-config/brevo-config.resolver.ts b/packages/api/src/brevo-config/brevo-config.resolver.ts index d807b510..e07f3e8c 100644 --- a/packages/api/src/brevo-config/brevo-config.resolver.ts +++ b/packages/api/src/brevo-config/brevo-config.resolver.ts @@ -30,11 +30,11 @@ export function createBrevoConfigResolver({ private async validateSender({ email, name }: { email: string; name: string }): Promise { const senders = await this.brevoSenderApiService.getSenders(); - if (!senders || !senders.some((sender) => sender.email === email && sender.name === name)) { - return false; + if (senders && senders.some((sender) => sender.email === email && sender.name === name)) { + return true; } - return true; + return false; } @RequiredPermission(["brevo-newsletter-config"], { skipScopeCheck: true })