[inbandif] VS tests for inbandif and remote neigh in asic db

Signed-off-by: vedganes <vedavinayagam.ganesan@nokia.com>

- Added tests for inband if (port type) and remote neigh programming in asic db
and kernel
- Fixed switch_id values in the system port config.

Author: vedganes

tests/conftest.py

@@ -1445,7 +1445,7 @@ def handle_neighconn(self):
     def get_chassis_instance_port_statuses(self):
         instance_to_port_status_map = {}
         if "neighbor_connections" not in self.virt_topo:
-            return instance_to_neighbor_map
+            return instance_to_port_status_map
 
         working_dir = os.getcwd()
         for conn, endpoints in self.virt_topo["neighbor_connections"].items():

tests/test_virtual_chassis.py

@@ -4,6 +4,40 @@
 import ast
 
 class TestVirtualChassis(object):
+
+    def config_inbandif_port(self, vct, ibport):
+        """This function configures port type inband interface in each linecard"""
+
+        dvss = vct.dvss
+        for name in dvss.keys():
+            dvs = dvss[name]
+            # Get the config info
+            config_db = dvs.get_config_db()
+            metatbl = config_db.get_entry("DEVICE_METADATA", "localhost")
+
+            cfg_switch_type = metatbl.get("switch_type")
+
+            # Configure only for line cards
+            if cfg_switch_type == "voq":
+                dvs.runcmd(f"config interface startup {ibport}")
+                config_db.create_entry("VOQ_INBAND_INTERFACE", f"{ibport}", {"inband_type": "port"})
+                
+    def del_inbandif_port(self, vct, ibport):
+        """This function deletes existing port type inband interface"""
+
+        dvss = vct.dvss
+        for name in dvss.keys():
+            dvs = dvss[name]
+            # Get the config info
+            config_db = dvs.get_config_db()
+            metatbl = config_db.get_entry("DEVICE_METADATA", "localhost")
+
+            cfg_switch_type = metatbl.get("switch_type")
+
+            # Applicable only for line cards
+            if cfg_switch_type == "voq":
+                config_db.delete_entry("VOQ_INBAND_INTERFACE", f"{ibport}")
+                
     def test_connectivity(self, vct):
         if vct is None:
             return
@@ -155,9 +189,24 @@ def test_chassis_system_neigh(self, vct):
         This test validates that:
            (i)   Local neighbor entry is created with encap index
            (ii)  Local neighbor is synced to chassis ap db with assigned encap index
-           TODO: (iii) Remote neighbor entry is created in ASIC_DB with received encap index
+           (iii) Remote neighbor entry is created in ASIC_DB with received encap index
         """
 
+        # We use Ethernet0 as inband port in each line card. In real hardware, this will be a
+        # special port used for inband. For testing purpose, we need port record and rif record
+        # for the inband interface and valid kernel interface. Since Ethernet0 is already 
+        # setup, the port record, rif record and kernel interface already exist. So we use it
+        # for testing
+        inband_port = "Ethernet0"
+
+        # Configure port type inband interface
+        self.config_inbandif_port(vct, inband_port)
+
+        # Test neighbor on Ethernet4 since Ethernet0 is used as Inband port
+        test_neigh_dev = "Ethernet4"
+        test_neigh_ip = "10.8.104.3"
+        test_neigh_mac = "00:01:02:03:04:05"
+
         dvss = vct.dvss
         for name in dvss.keys():
             dvs = dvss[name]
@@ -174,7 +223,7 @@ def test_chassis_system_neigh(self, vct):
                 if lc_switch_id == "0":
 
                     # Add a static neighbor
-                    _, res = dvs.runcmd(['sh', "-c", "ip neigh add 10.8.101.2 lladdr 00:01:02:03:04:05 dev Ethernet0"])
+                    _, res = dvs.runcmd(['sh', "-c", f"ip neigh add {test_neigh_ip} lladdr {test_neigh_mac} dev {test_neigh_dev}"])
                     assert res == "", "Error configuring static neigh"
 
                     asic_db = dvs.get_asic_db()
@@ -185,7 +234,7 @@ def test_chassis_system_neigh(self, vct):
                     test_neigh = ""
                     for nkey in neighkeys:
                         ne = ast.literal_eval(nkey)
-                        if ne['ip'] == '10.8.101.2':
+                        if ne['ip'] == test_neigh_ip:
                             test_neigh = nkey
                             break
 
@@ -211,7 +260,7 @@ def test_chassis_system_neigh(self, vct):
                 for sysnk in sysneighkeys:
                     sysnk_tok = sysnk.split("|")
                     assert len(sysnk_tok) == 3, "Invalid system neigh key in chassis app db"
-                    if sysnk_tok[2] == "10.8.101.2":
+                    if sysnk_tok[2] == test_neigh_ip:
                         test_sysneigh = sysnk
                         break
 
@@ -224,7 +273,79 @@ def test_chassis_system_neigh(self, vct):
                 assert encap_index == sys_neigh_encap_index, "Encap index not sync-ed correctly"
 
                 break
+            
+        # Verify programming of remote neighbor in asic db and programming of static route and static
+        # neigh in the kernel for the remote neighbor. The neighbor created in linecard 1  will be a 
+        # remote neighbor in other linecards. Verity existence of the test neighbor in  linecards other 
+        # than linecard 1
+        dvss = vct.dvss
+        for name in dvss.keys():
+            dvs = dvss[name]
+
+            config_db = dvs.get_config_db()
+            metatbl = config_db.get_entry("DEVICE_METADATA", "localhost")
+
+            cfg_switch_type = metatbl.get("switch_type")
+
+            # Neighbor record verifiation done in line card
+            if cfg_switch_type == "voq":    
+                lc_switch_id = metatbl.get("switch_id")
+                assert lc_switch_id != "", "Got error in getting switch_id from CONFIG_DB DEVICE_METADATA"
+                if lc_switch_id != "0":
+                    # Linecard other than linecard 1
+                    asic_db = dvs.get_asic_db()
+                    neighkeys = asic_db.get_keys("ASIC_STATE:SAI_OBJECT_TYPE_NEIGHBOR_ENTRY")
+                    assert len(neighkeys), "No neigh entries in ASIC_DB"
+                    
+                    # Check for presence of the remote neighbor in ASIC_DB
+                    remote_neigh = ""
+                    for nkey in neighkeys:
+                        ne = ast.literal_eval(nkey)
+                        if ne['ip'] == test_neigh_ip:
+                            remote_neigh = nkey
+                            break
+                        
+                    assert remote_neigh != "", "Remote neigh not found in ASIC_DB"
+                    
+                    # Check for kernel entries
+
+                    _, output = dvs.runcmd("ip neigh show")
+                    assert f"{test_neigh_ip} dev {inband_port}" in output, "Kernel neigh not found for remote neighbor"
 
+                    _, output = dvs.runcmd("ip route show")
+                    assert f"{test_neigh_ip} dev {inband_port} scope link" in output, "Kernel route not found for remote neighbor"
+                   
+                    # Check for ASIC_DB entries. 
+
+                    # Check for presence of encap index, retrieve and store it for sync verification
+                    remote_neigh_entry = asic_db.get_entry("ASIC_STATE:SAI_OBJECT_TYPE_NEIGHBOR_ENTRY", remote_neigh)
+                    
+                    # Validate encap index
+                    remote_encap_index = remote_neigh_entry.get("SAI_NEIGHBOR_ENTRY_ATTR_ENCAP_INDEX")
+                    assert remote_encap_index != "", "VOQ encap index is not programmed for remote neigh in ASIC_DB"
+                    assert remote_encap_index == encap_index, "Encap index of remote neigh mismatch with allocated encap index"
+                    
+                    # Validate MAC
+                    mac = remote_neigh_entry.get("SAI_NEIGHBOR_ENTRY_ATTR_DST_MAC_ADDRESS")
+                    assert mac != "", "MAC address is not programmed for remote neigh in ASIC_DB"
+                    assert mac == test_neigh_mac, "Encap index of remote neigh mismatch with allocated encap index"
+                    
+                    # Check for other mandatory attributes
+                    # For remote neighbor, encap index must be imposed. So impose_index must be "true"
+                    impose_index = remote_neigh_entry.get("SAI_NEIGHBOR_ENTRY_ATTR_ENCAP_IMPOSE_INDEX")
+                    assert impose_index != "", "Impose index attribute is not programmed for remote neigh in ASIC_DB"
+                    assert impose_index == "true", "Impose index attribute is false for remote neigh"
+                   
+                    # For remote neighbors, is_local must be "false" 
+                    is_local = remote_neigh_entry.get("SAI_NEIGHBOR_ENTRY_ATTR_IS_LOCAL")
+                    assert is_local != "", "is_local attribute is not programmed for remote neigh in ASIC_DB"
+                    assert is_local == "false", "is_local attribute is true for remote neigh"
+                    
+                    break
+                
+        # Cleanup
+        self.del_inbandif_port(vct, inband_port)
+                    
 # Add Dummy always-pass test at end as workaroud
 # for issue when Flaky fail on final test it invokes module tear-down before retrying
 def test_nonflaky_dummy():