[voq/inband]Inband port name change

Signed-off-by: vedganes <vedavinayagam.ganesan@nokia.com>

Based on review comments Recyle port HLD
(sonic-net/SONiC#742) the inband port name prefix is
changed from Inband to "Ethernet-IB" similar to what we have for
Ethernet-BP (Ethernet-Backplane) in multi-asic design. Because of this
changes, we no longer need "INBAND_PREFIX" definition since Ethernet-IB
is covered in "INTFS_PREIFX"

Author: vedganes

portsyncd/linksync.cpp

@@ -30,7 +30,6 @@ using namespace swss;
 const string MGMT_PREFIX = "eth";
 const string INTFS_PREFIX = "Ethernet";
 const string LAG_PREFIX = "PortChannel";
-const string INBAND_PREFIX = "Inband";
 
 extern set<string> g_portSet;
 extern bool g_init;
@@ -168,8 +167,7 @@ void LinkSync::onMsg(int nlmsg_type, struct nl_object *obj)
 
     if (key.compare(0, INTFS_PREFIX.length(), INTFS_PREFIX) &&
         key.compare(0, LAG_PREFIX.length(), LAG_PREFIX) &&
-        key.compare(0, MGMT_PREFIX.length(), MGMT_PREFIX) &&
-        key.compare(0, INBAND_PREFIX.length(), INBAND_PREFIX))
+        key.compare(0, MGMT_PREFIX.length(), MGMT_PREFIX))
     {
         return;
     }