Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo page history navigation breaks top navbar #20

Open
Renerick opened this issue Feb 5, 2025 · 5 comments
Open

Demo page history navigation breaks top navbar #20

Renerick opened this issue Feb 5, 2025 · 5 comments

Comments

@Renerick
Copy link

Renerick commented Feb 5, 2025

Bug description

When navigating backwards and forwards through history on the demo site, the navbar is removed and only restored by page refresh

Reproduction project

https://demo.unpoly.com/

Steps to reproduce the behavior:

  1. Go to reproduction project linked above
  2. Click on 'Companies'
  3. Click the Back button
  4. Navbar is gone

Expected behavior

Navbar is not gone upon history restoration

Browser version

  • OS: Windows, MacOS
  • Browser: Firefox, Chrome and Edge
  • Version [e.g. 22]

Additional context

Image

@hpvd
Copy link

hpvd commented Feb 6, 2025

same in FF135 on windows 11
with first click of browsers back-button Navbar is gone

@hpvd
Copy link

hpvd commented Feb 6, 2025

@Renerick
there is a own repo with issue tracker for the demo:
https://github.com/unpoly/unpoly-demo

@Renerick
Copy link
Author

Renerick commented Feb 6, 2025

Sorry, my bad.

Feel free to move the issue there or let me know if I should open a new one myself

@adam12 adam12 transferred this issue from unpoly/unpoly Feb 6, 2025
@adam12
Copy link
Member

adam12 commented Feb 6, 2025

@Renerick Thanks for the report :) I've moved the issue.

@augustogoulart
Copy link

While the Ruby demo silently renders the fragments instead of the whole page when you use the back button, the Django demo allows you to go back one page, but then it crashes (I know it's a different project, but just highlighting a similar problem)

Screen.Recording.2025-03-10.at.23.37.45.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants