Replies: 1 comment 1 reply
-
Agreed. In fact, that was the original intention I believe, but PRs started going up before anything was agreed upon. This is a good place to brainstorm. Circuit generation
Result combination
Of my limited brainstorm, |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Looking at the different techniques that have been modularized, there are inconsistencies.
ZNE, PEC, and DDD have one function that generates the circuits and another that provides the final expectation value.
LRE has a function that generates the circuits and one that generates the coefficients used in generating the final expectation value.
ZNE:
scaled_circuits
andcombine_results
PEC:
generate_sampled_circuits
andcombine_results
DDD:
generate_circuits_with_ddd
andcombine_results
LRE:
multivariate_layer_scaling
andmultivariate_richardson_coefficients
I think it would be useful to have the function that generates the circuits to have the same naming convention. Also, I think adding a
combine_results
to LRE makes sense for consistency.Beta Was this translation helpful? Give feedback.
All reactions