New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Page to a PageLayout component #69

Open

3 tasks

tskarhed opened this issue Oct 1, 2020 · 0 comments

Labels

hacktoberfest medium difficulty

Owner

tskarhed commented Oct 1, 2020

The Page component was written in quite a hurry without much planning. A lot of the concerns are not separated. There are some aspects to this

Extract the pure layout areas into a PageLayout components
https://github.com/tskarhed/setlist/blob/9fb3bf27a34fb5e15bf4456c329f55b3fa75fda5/src/views/Page.tsx#L96
Extract the title editing into a proper component (which can be used on relevant pages)
https://github.com/tskarhed/setlist/blob/9fb3bf27a34fb5e15bf4456c329f55b3fa75fda5/src/views/Page.tsx#L61
Extract Search. Best case here would be to have it on a much higher level
https://github.com/tskarhed/setlist/blob/9fb3bf27a34fb5e15bf4456c329f55b3fa75fda5/src/views/Page.tsx#L35

The text was updated successfully, but these errors were encountered:

tskarhed added hacktoberfest medium difficulty labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment